Repository navigation
feat(sdk-coin-sol): validate v1 transaction signatures on broadcast - #9852
Merged
bhavidhingra merged 4 commits intoSep 29, 2026
Merged
Conversation
Contributor
Contributor
|
|
MohammedRyaan786
approved these changes
Sep 29, 2026
harman-bitgo
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives v1 (SIMD-0296/0385) Solana transactions the same broadcast-time validation as legacy/v0: structural decode + require-all-signatures + ed25519 signature verification, instead of the current size-only check.
Changes
serialization/codecs/v1/message.ts: adddecodeV1Message- structural v1 message decoder (version 0x81, header, config mask, blockhash, static accounts, config values, instructions) with bounds-safe truncation errors.serialization/parseWireTransaction.ts(new):parseWireTransaction(splits message vs tail signatures, enforces 4096-byte v1 limit) +verifyV1Signatures+validateRawTransactionV1(ed25519 verify each sig over messageBytes).sol.ts: v1 branch ofbroadcastTransactionnow callsvalidateRawTransactionV1after the size check, matching the legacyvalidateRawTransaction(raw, true, true)parity.Refs: CHALO-1602