Skip to content

feat(support flush coins): support flushing native ETH coin - #985

Merged
glowang merged 1 commit into
masterfrom
BG-28129-support-flush-coins
Jan 14, 2021
Merged

glowang merged 1 commit into
masterfrom
BG-28129-support-flush-coins

Conversation

@glowang

@glowang glowang commented Jan 11, 2021 •

Copy link
Copy Markdown
Contributor

Sometimes, clients might send ETH to an address before the wallet deployment tx has been confirmed due to fee spike, which results in ETH stuck in forwarders that need to be flushed.

This PR adds a transaction type to the ETH transaction builder. This allows us to build flush tx in Wallet Platform later.

@glowang glowang changed the title feat(support flush coins): support flushing coins feat(support flush coins): support flushing native ETH coin Jan 11, 2021
@glowang
glowang force-pushed the BG-28129-support-flush-coins branch from 3345bf0 to 2afcddf Compare January 12, 2021 17:38
@codecov

codecov Bot commented Jan 12, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #985 (2afcddf) into master (0b9e35b) will increase coverage by 6.90%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   57.93%   64.83%   +6.90%     
==========================================
  Files         109      183      +74     
  Lines       10340    13400    +3060     
  Branches     1985     2466     +481     
==========================================
+ Hits         5990     8688    +2698     
- Misses       3541     3746     +205     
- Partials      809      966     +157     
Flag Coverage Δ
unit 64.82% <88.23%> (+6.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...les/account-lib/src/coin/eth/transactionBuilder.ts 87.55% <77.77%> (ø)
modules/account-lib/src/coin/baseCoin/enum.ts 100.00% <100.00%> (ø)
modules/account-lib/src/coin/eth/utils.ts 80.80% <100.00%> (ø)
modules/account-lib/src/coin/eth/walletUtil.ts 100.00% <100.00%> (ø)
modules/account-lib/src/coin/trx/utils.ts 80.20% <0.00%> (ø)
...dules/account-lib/src/coin/celo/transferBuilder.ts 85.71% <0.00%> (ø)
modules/account-lib/src/coin/trx/keyPair.ts 91.30% <0.00%> (ø)
modules/account-lib/src/coin/xtz/index.ts 100.00% <0.00%> (ø)
...dules/account-lib/src/coin/cspr/transferBuilder.ts 43.47% <0.00%> (ø)
modules/account-lib/src/coin/xtz/keyPair.ts 96.07% <0.00%> (ø)
... and 69 more

@glowang
glowang marked this pull request as ready for review January 12, 2021 17:57
@glowang
glowang requested a review from tylerlevine as a code owner January 12, 2021 17:57
@glowang
glowang requested review from marktoda and wesgraham January 12, 2021 17:58

@marktoda marktoda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! LGTM.

@glowang
glowang merged commit f510d5d into master Jan 14, 2021
@tylerlevine

Copy link
Copy Markdown
Contributor

next time, please avoid adding console.log s to the tests - these make the tests very noisy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants