Skip to content

feat(sdk-coin-sol): cover remaining CT ops in v1 + APB ordering - #9810

Closed
bhavidhingra wants to merge 3 commits into
bhavi/chalo-1602-pr2-ct-v1from
bhavi/chalo-1602-pr3-ct-ops
Closed

bhavidhingra wants to merge 3 commits into
bhavi/chalo-1602-pr2-ct-v1from
bhavi/chalo-1602-pr3-ct-ops

Conversation

@bhavidhingra

@bhavidhingra bhavidhingra commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Complete Solana v1 (SIMD-0296/0385) Confidential Transfer coverage: force ApplyPendingBalance ordering and add per-op v1 tests.

Changes

  • ConfidentialTransferBuilder.buildV1: force ApplyPendingBalance to instruction Add README for examples directory #1 in v1 spend transactions (idempotent), regardless of caller order.
  • New confidentialTransferV1Ops.ts unit tests: Deposit, Withdraw (with equality + range proofs), private Transfer (with all proofs), ConfigureAccount + VerifyPubkeyValidity, and each verify-proof instruction. Each asserts the 0x81 prefix, config preservation, and the 4096-byte wire limit. ApplyPendingBalance ordering is tested via a deliberately out-of-order call.

Notes

  • v1 wire size limit: 4096 bytes (SIMD-0385 / @solana/transactions).
  • Devnet live broadcasts of the remaining CT ops pending a live RPC and funded accounts.

Testing

  • sdk-coin-sol: 756 passing (incl. 6 new per-op v1 tests)
  • Typecheck clean; prettier + ascii scans clean.

Refs: CHALO-1602

@bhavidhingra
bhavidhingra requested a review from a team as a code owner September 24, 2026 08:39
@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

CHALO-1602

@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from 908be73 to b874f3f Compare September 25, 2026 08:16
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@rishikeshdadam136 rishikeshdadam136 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flushing
Wallets team review not needed here

@bhavidhingra
bhavidhingra removed this pull request from stack #9819 September 25, 2026 16:05
@bhavidhingra
bhavidhingra removed this pull request from stack #9831 September 28, 2026 07:40
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr2-ct-v1 branch from f659c42 to 99c3287 Compare September 28, 2026 08:37
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from 5d60ea9 to 7a3a72e Compare September 28, 2026 08:38
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from 7a3a72e to a3a856e Compare September 28, 2026 09:46
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr2-ct-v1 branch from ec0df1e to e658fe9 Compare September 28, 2026 10:44
@bhavidhingra
bhavidhingra removed this pull request from stack #9833 September 28, 2026 10:47
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from a3a856e to 6fe2572 Compare September 28, 2026 10:48
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr2-ct-v1 branch from e658fe9 to 6447a0d Compare September 28, 2026 11:23
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from 6fe2572 to 8aba1af Compare September 28, 2026 11:23

@harman-bitgo harman-bitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add version(1)/transactionConfig setters to the confidential transfer
builder and assemble v1 transactions (0x81, inline config, message-first
wire format) via the v1 compiler/serializer. Persist the v1 wire and
message bytes on the transaction, expose them through toBroadcastFormat,
signablePayload, and id, and guard v1 broadcast size against the 4096-byte
limit. Add unit tests for the v1 CT path.

Refs: CHALO-1602
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr2-ct-v1 branch 2 times, most recently from e296708 to 8559f5d Compare September 29, 2026 12:27
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from 8aba1af to bf5ca79 Compare September 29, 2026 12:27
Force ApplyPendingBalance to instruction #1 in v1 spend transactions
(regardless of caller order; it is idempotent) and add per-op v1 tests
for Deposit, Withdraw, private Transfer, ConfigureAccount, and each
verify-proof instruction, asserting the 0x81 prefix, config preservation,
and the 4096-byte wire limit.

Refs: CHALO-1602
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr3-ct-ops branch from bf5ca79 to 623e59c Compare September 29, 2026 14:07
@bhavidhingra
bhavidhingra force-pushed the bhavi/chalo-1602-pr2-ct-v1 branch from 3c79f6b to 0162db4 Compare September 29, 2026 15:34
@bhavidhingra

Copy link
Copy Markdown
Contributor Author

Superseded by #9809 (PRs clubbed into one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants