Repository navigation
feat(sdk-coin-sol): cover remaining CT ops in v1 + APB ordering - #9810
Closed
bhavidhingra wants to merge 3 commits into
Closed
bhavidhingra wants to merge 3 commits into
bhavidhingra wants to merge 3 commits into
Conversation
Contributor
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 25, 2026 08:16
908be73 to
b874f3f
Compare
Contributor
|
|
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 25, 2026 08:39
c215985 to
cbe4430
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 25, 2026 08:41
b874f3f to
d5fe0cc
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 25, 2026 09:31
cbe4430 to
f659c42
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 25, 2026 09:32
d5fe0cc to
f659c42
Compare
rishikeshdadam136
left a comment
Contributor
There was a problem hiding this comment.
Flushing
Wallets team review not needed here
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 28, 2026 08:37
f659c42 to
99c3287
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 28, 2026 08:38
5d60ea9 to
7a3a72e
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 28, 2026 09:46
7a3a72e to
a3a856e
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 28, 2026 10:44
ec0df1e to
e658fe9
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 28, 2026 10:48
a3a856e to
6fe2572
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 28, 2026 11:23
e658fe9 to
6447a0d
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 28, 2026 11:23
6fe2572 to
8aba1af
Compare
Add version(1)/transactionConfig setters to the confidential transfer builder and assemble v1 transactions (0x81, inline config, message-first wire format) via the v1 compiler/serializer. Persist the v1 wire and message bytes on the transaction, expose them through toBroadcastFormat, signablePayload, and id, and guard v1 broadcast size against the 4096-byte limit. Add unit tests for the v1 CT path. Refs: CHALO-1602
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
2 times, most recently
from
September 29, 2026 12:27
e296708 to
8559f5d
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 29, 2026 12:27
8aba1af to
bf5ca79
Compare
Force ApplyPendingBalance to instruction #1 in v1 spend transactions (regardless of caller order; it is idempotent) and add per-op v1 tests for Deposit, Withdraw, private Transfer, ConfigureAccount, and each verify-proof instruction, asserting the 0x81 prefix, config preservation, and the 4096-byte wire limit. Refs: CHALO-1602
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr3-ct-ops
branch
from
September 29, 2026 14:07
bf5ca79 to
623e59c
Compare
bhavidhingra
force-pushed
the
bhavi/chalo-1602-pr2-ct-v1
branch
from
September 29, 2026 15:34
3c79f6b to
0162db4
Compare
Contributor
Author
|
Superseded by #9809 (PRs clubbed into one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete Solana v1 (SIMD-0296/0385) Confidential Transfer coverage: force ApplyPendingBalance ordering and add per-op v1 tests.
Changes
ConfidentialTransferBuilder.buildV1: force ApplyPendingBalance to instruction Add README for examples directory #1 in v1 spend transactions (idempotent), regardless of caller order.confidentialTransferV1Ops.tsunit tests: Deposit, Withdraw (with equality + range proofs), private Transfer (with all proofs), ConfigureAccount + VerifyPubkeyValidity, and each verify-proof instruction. Each asserts the 0x81 prefix, config preservation, and the 4096-byte wire limit. ApplyPendingBalance ordering is tested via a deliberately out-of-order call.Notes
Testing
Refs: CHALO-1602