Skip to content

feat(statics): onboard Robinhood EVM stock tokens batch #3 - #9590

Merged
hirenmaySam merged 1 commit into
masterfrom
hirenmaysamanta/chalo-1369-robinhood-evm-batch-3
Aug 28, 2026
Merged

hirenmaySam merged 1 commit into
masterfrom
hirenmaysamanta/chalo-1369-robinhood-evm-batch-3

Conversation

@hirenmaySam

@hirenmaySam hirenmaySam commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Onboards 90 new Robinhood Chain (HoodETH) tokenized stock/ETF tokens per CHALO-1369, following the token onboarding doc's Step 1 (SDK statics).
  • Adds UnderlyingAsset enum entries, erc20Token definitions in hoodethTokens.ts, and matching ofcerc20 OFC equivalents in ofcHoodethTokens.ts.
  • Skipped HoodETH:ZETA and HoodETH:QNT — both already onboarded in a prior batch with the same contract address.

Test plan

  • yarn build (statics) — clean build, no TS errors
  • yarn unit-test --scope @bitgo/statics — 35,961 passing
  • npx eslint on changed files — clean
  • Verified no duplicate UUIDs/contract addresses/token types across the full statics repo (via should fail if asset ids are not unique, should have no duplicate contract addresses, etc.)

TICKET: CHALO-1369

@hirenmaySam
hirenmaySam requested a review from a team as a code owner August 28, 2026 10:04
@linear-code

linear-code Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

CHALO-1369

@yashvanthbl137-crypto

Copy link
Copy Markdown
Contributor

@claude review this PR

@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @yashvanthbl137-crypto's task —— View job


Code Review: Robinhood EVM Stock Tokens Batch #3

Todo List:

  • Read repository guidelines (CLAUDE.md)
  • Review base.ts changes (UnderlyingAsset enum additions)
  • Review hoodethTokens.ts changes (ERC20 token definitions)
  • Review ofcHoodethTokens.ts changes (OFC equivalent definitions)
  • Check for consistency and patterns
  • Provide comprehensive review feedback

Review Summary

This PR successfully adds 90 new Robinhood Chain (HoodETH) tokenized stock/ETF tokens following the established patterns. The implementation is consistent and well-structured.

✅ Strengths

  1. Consistent Structure: All token definitions follow the exact same pattern as existing tokens
  2. Proper Organization: Changes are appropriately distributed across the three required files:
    • base.ts: UnderlyingAsset enum entries (+90 lines)
    • hoodethTokens.ts: ERC20 token definitions (+900 lines)
    • ofcHoodethTokens.ts: OFC equivalent definitions (+1260 lines)
  3. Unique Identifiers: All 181 UUIDs are unique (verified no duplicates)
  4. Standard Configuration: Proper use of EVM_ERC20_TOKEN_FEATURES_EXCLUDE_SINGAPORE and Networks.main.hoodeth
  5. Complete Coverage: Each new token has matching entries in all three files
  6. Author Testing: Good test coverage mentioned (build, unit tests, eslint, duplicate checks)

🔍 Key Observations

  • Token Count: Exactly 90 new tokens as stated (90×3 = 270 definitions + 90 enum entries = 360 total additions per math, close to the 486 symbol mentions found)
  • Naming Convention: Consistent hoodeth:<symbol> pattern for underlying assets
  • Contract Addresses: All use valid Ethereum address format (0x followed by 40 hex chars)
  • Decimals: All tokens use 18 decimals (standard ERC20)
  • Skipped Tokens: Author correctly noted skipping ZETA and QNT due to existing entries

📝 Minor Notes

  1. Anthropic Token: Interesting to see hoodeth:anth (Anthropic) included - presumably a legitimate tokenized stock
  2. ETF Inclusion: Mix of individual stocks and ETFs (e.g., hodu - "Direxion Daily HOOD Bull 2X ETF")
  3. Pattern Adherence: Perfect adherence to existing code patterns and conventions

🎯 Recommendation

✅ APPROVE - This PR is well-implemented, follows established patterns perfectly, and appears to have been thoroughly tested. The changes are purely additive and low-risk.

The implementation demonstrates good attention to detail and proper understanding of the codebase architecture for token onboarding.

@MohammedRyaan786 MohammedRyaan786 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirenmaySam
hirenmaySam merged commit b46bf75 into master Aug 28, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants