Repository navigation
WIN-4641-1 | Transaction builder for ICP - #5570
Closed
mohd-kashif wants to merge 10 commits into
Closed
mohd-kashif wants to merge 10 commits into
mohd-kashif wants to merge 10 commits into
Conversation
mohd-kashif
force-pushed
the
WIN-4635
branch
3 times, most recently
from
February 18, 2025 17:54
b85a68f to
93d84d4
Compare
mohd-kashif
force-pushed
the
WIN-4641-1
branch
from
February 18, 2025 21:06
140bc89 to
67c6449
Compare
DinshawKothari
suggested changes
Feb 20, 2025
DinshawKothari
suggested changes
Feb 20, 2025
mohd-kashif
force-pushed
the
WIN-4641-1
branch
from
February 21, 2025 06:31
40f2884 to
d5557cd
Compare
mohd-kashif
force-pushed
the
WIN-4641-1
branch
from
February 25, 2025 18:56
5efa170 to
58d27e0
Compare
mohd-kashif
force-pushed
the
WIN-4641-1
branch
from
February 27, 2025 08:29
58d27e0 to
ea4cc9f
Compare
…or ICP transactions TICKET: WIN-4641
mohd-kashif
marked this pull request as ready for review
February 27, 2025 11:23
mohd-kashif
marked this pull request as draft
February 27, 2025 11:23
mohd-kashif
marked this pull request as ready for review
February 28, 2025 01:11
Vijay-Jagannathan
left a comment
Contributor
There was a problem hiding this comment.
flushing from queue, you'll need to squash commits before review
Contributor
|
Please add a testcase for memo where alphanumeric or string memo fails as it is not supported by chain. |
…saction handling TICKET: WIN-4641
Contributor
|
The code changes look good to me. Please squash the commits and take a look at the build failure. Overall, I appreciate the significant effort and good work put into this. Keep up the great work — thanks! |
Contributor
Author
|
closed this PR as i have picked the commits and open another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-4641