Skip to content

WIN-4641-1 | Transaction builder for ICP - #5570

Closed
mohd-kashif wants to merge 10 commits into
masterfrom
WIN-4641-1
Closed

mohd-kashif wants to merge 10 commits into
masterfrom
WIN-4641-1

Conversation

@mohd-kashif

Copy link
Copy Markdown
Contributor

TICKET: WIN-4641

@mohd-kashif mohd-kashif self-assigned this Feb 18, 2025
@mohd-kashif mohd-kashif changed the title WIN-4641-1 WIN-4641-1 | Transaction validation for ICP Feb 18, 2025
@mohd-kashif
mohd-kashif force-pushed the WIN-4635 branch 3 times, most recently from b85a68f to 93d84d4 Compare February 18, 2025 17:54
Base automatically changed from WIN-4635 to master February 19, 2025 06:07
@mohd-kashif mohd-kashif changed the title WIN-4641-1 | Transaction validation for ICP WIN-4641-1 | Transaction builder for ICP Feb 20, 2025
Comment thread modules/sdk-coin-icp/package.json Resolved
Comment thread modules/sdk-coin-icp/src/icp.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/utils.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/utils.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/utils.ts Resolved
Comment thread modules/sdk-coin-icp/test/unit/utils.ts Resolved
@mohd-kashif
mohd-kashif marked this pull request as ready for review February 27, 2025 11:23
@mohd-kashif
mohd-kashif requested a review from a team February 27, 2025 11:23
@mohd-kashif
mohd-kashif marked this pull request as draft February 27, 2025 11:23
@mohd-kashif
mohd-kashif marked this pull request as ready for review February 28, 2025 01:11

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flushing from queue, you'll need to squash commits before review

Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/iface.ts Resolved
Comment thread modules/sdk-coin-icp/src/lib/utils.ts Resolved
Comment thread modules/sdk-coin-icp/test/unit/utils.ts Resolved
@DinshawKothari

Copy link
Copy Markdown
Contributor

Please add a testcase for memo where alphanumeric or string memo fails as it is not supported by chain.

@DinshawKothari

Copy link
Copy Markdown
Contributor

The code changes look good to me. Please squash the commits and take a look at the build failure.

Overall, I appreciate the significant effort and good work put into this. Keep up the great work — thanks!

@mohd-kashif mohd-kashif closed this Mar 3, 2025
@mohd-kashif

Copy link
Copy Markdown
Contributor Author

closed this PR as i have picked the commits and open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants