Repository navigation
fix(sdk-coin-avaxc): inherit isWalletAddress verification from AbstractEthLikeNewCoins #10185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1230,11 +1230,6 @@ export class AvaxC extends AbstractEthLikeNewCoins { | |
| return hash.digest(); | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟣 pre-existing, not blocking: Pre-existing, security-relevant: AVAXC TSS wallets still accept any deposit address when the platform reply says Why this was flaggedWallet.createAddress (sdk-core/src/bitgo/wallet/wallet.ts:1561) sets Verification: In wallet.ts:1561, |
||
| async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> { | ||
| // TODO: Fix this later | ||
| return true; | ||
| } | ||
|
|
||
| /** | ||
| * Ensure either enterprise or newFeeAddress is passed, to know whether to create new key or use enterprise key | ||
| * @param params | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.