Repository navigation
feat(statics): onboard CECHO-2732 mon:usdt0 and eth:stampx - #10181
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
@claude review |
|
Claude finished @manojkumar138's task in 15s —— View job Review of PR #10181: onboard
|
|
|
73b8905 to
f896502
Compare
|
@claude review |
|
Claude finished @manojkumar138's task in 34s —— View job Review of PR #10181The new token entries look right. I found one likely bug in Fix before merge
Description vs. diff Checked and fine
Not verified
|
f896502 to
8369279
Compare
|
@claude review |
|
Claude finished @manojkumar138's task in 18s —— View job Review of PR #10181The token and OFC entries look correct, apart from the features on Fix before merge
Description cleanup Checked and fine
Not verified
|
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Beyond the inline finding, I checked two other things and ruled them out. ofcmon:usdt0 sits in the testnet tOfcErc20Coins array but points to the mainnet mon:usdt0. The existing ofcmon:usdc and ofcmon:wmon sit in that same array, so this placement follows the existing pattern. The wider account-coin feature set on ofcsol:cash was also examined and not raised as a bug.
Extended reasoning...
The change adds coin-registry data only to @ bitgo/statics: two UnderlyingAsset enum values, two base tokens, and eight new OFC entries. It touches no auth, crypto or permission code. The note covers only placement and feature-set checks that no earlier review body on this PR covered.
8369279 to
2e86140
Compare
|
@claude re-review |
There was a problem hiding this comment.
Beyond the inline finding, I also looked at ofcmon:usdt0 sitting inside tOfcErc20Coins. It is not a problem: ofcerc20 sets the network to mainnet OFC on its own, and the existing mainnet entries ofcmon:usdc and ofcmon:wmon live in the same array.
Extended reasoning...
The PR adds static token definitions to @ bitgo/statics (new UnderlyingAsset entries, ERC20, Monad and OFC tokens) and bumps one devDependency in key-card. The only thing this note rules out is the testnet-array placement. The network for ofcerc20 comes from its default parameter (Networks.main.ofc in ofc.ts), not from which array the entry is in.
Still open from earlier reviews (1):
- Unresolved: 1 minor or pre-existing.
|
Claude finished @manojkumar138's task in 21s —— View job Re-review of PR #10181The only open item is a small optional one: Resolved since the last review
Optional
Not verified
Nothing else blocks merge. |
2e86140 to
a36d602
Compare
|
@claude re-review |
|
Claude finished @manojkumar138's task in 20s —— View job Re-review of PR #10181There is one blocker: the commit deletes the existing Fix before merge
Resolved since the last review
Optional (still open) Checked and fine
Not verified
|
a36d602 to
e91e314
Compare
|
Addressed the re-review findings (amended commit 1. Blocker — 2. Optional — Worth noting for the record: by the same mechanism Validation on the amended commit
|
|
@claude re-review |
|
Claude finished @manojkumar138's task in 17s —— View job Re-review of PR #10181I found no blocking issues. I read the amended commit Resolved since the last review
Checked and fine
Not verified
The PR looks good to merge once CI is green. |
6cea9ed to
57bc524
Compare
…ounterparts Adds two client-requested tokens for the CECHO-2732 ticket's OVC and Express releases, plus OFC counterparts for all ticket tokens: - mon:usdt0 (USDT0) on Monad mainnet: 6 decimals, 0xe7cd86e13ac4309349f30b3435a9d337750fc82d (symbol/decimals verified on-chain via eth_call on rpc.monad.xyz) - eth:stampx (STAMPx) on Ethereum mainnet: 18 decimals, 0xc0aca7acdd9adeed3177a4b299caebe816842f52 (symbol/decimals verified on-chain via eth_call; note 18, not the 6 typical of wrapped assets) OFC counterparts added for all 8 CECHO-2732 tokens (the 6 from batch 11/12 plus these two): - ofchoodeth:rlusd (ofcHoodethTokens.ts) - ofcxlm:SPXU-... (ofcStellarToken, ACCOUNT_COIN_DEFAULT_FEATURES_TRUST_ONLY to mirror the base token's Trust-only custody; the mixed-case Stellar name never matches getFilteredFeatures' lowercase lookup, so the features must be passed explicitly) - ofccanton:beth/usty/exau/exag (ofcCantonToken) - ofcthbar:fly (tofcHederaToken, 'Fluency (Testnet)' per naming rule) - ofcsol:cash (ofcsolToken, UnderlyingAsset.CASH, 6 decimals, [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN] matching ofcsol:usdc; the underlying sol:cash is a stablecoin) - ofcmon:usdt0, ofceth:stampx (ofcerc20, STABLECOIN on usdt0) ofcxlm:SPXU-... is added to the 'WTGXX Trust-only custody' test to lock the behavior in. USDT0 is priced on CoinGecko (live, $1 pegged); STAMPx has no CryptoCompare pricing yet. Ticket: CECHO-2732
57bc524 to
d676f7d
Compare
|
@claude re-review |
|
Claude finished @manojkumar138's task in 21s —— View job Re-review of PR #10181I found no blocking issues. I read the diff against Checked
Optional nit
Not verified
The PR looks good to merge once CI is green. |
CECHO-2732 — onboard mon:usdt0 and eth:stampx
Adds two client-requested tokens bolted onto the CECHO-2732 ticket (per Rishi's comment, for the OVC and Express releases), following PR #10172 (batch 11/12).
mon:usdt00x8f)0xe7cd86e13ac4309349f30b3435a9d337750fc82deth:stampx0x1)0xc0aca7acdd9adeed3177a4b299caebe816842f52Changes
base.ts— newUnderlyingAssetentries:mon:usdt0(Monad mainnet block),eth:stampx.allCoinsAndTokens.ts—monErc20(...)USDT0 entry appended to the MON mainnet tokens.coins/erc20Coins.ts—erc20(...)STAMPx entry appended aftereth:spxux.Details
mon:usdt0— symbol/name read viaeth_call(symbol()=USDT0,decimals()= 6) onrpc.monad.xyz; also confirmed as themonadplatform entry on CoinGecko (usdt0, live price ~$1).eth:stampx— symbol/decimals read viaeth_callon Ethereum mainnet =STAMPx,decimals()= 18 (cross-checked on two independent RPCs: publicnode + drpc). No CoinGecko/CryptoCompare entry exists for STAMPx yet.botTokens.ts/botOfcTokens.tschanges, mirroring PR feat(statics): onboard CECHO-2732 client requested tokens batch (11/12) #10172's approach for ungated platform tokens).OFC counterparts
Added
ofc*tokens for all 8 CECHO-2732 tokens (the 6 from batch 11/12 that shipped in statics 2204, plus the 2 above), following the existing per-chain patterns:ofchoodeth:rlusd(ofcHoodethTokens.ts,ofcerc20, Robinhood fullName convention)ofcxlm:SPXU-…(ofcStellarToken, 7 decimals)ofccanton:beth/usty/exau/exag(ofcCantonToken, 10 decimals)ofcthbar:fly(tofcHederaToken, testnet — fullNameFluency (Testnet)per the OFC naming rule)ofcsol:cash(ofcsolToken,UnderlyingAsset.CASH, 6 decimals,[...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN]matchingofcsol:usdc— the underlyingsol:cashis a stablecoin)ofcmon:usdt0(ofcerc20, STABLECOIN feature likeofcmon:usdc)ofceth:stampx(ofcerc20, defaults)Split out of this PR
modules/key-card/package.json@bitgo/sdk-lib-mpcbump moved to PR #10182 per review feedback. This PR is now statics-only.Validation
tsc --noEmit -p modules/statics— clean.prettier --checkclean on all changed statics files.Ticket: CECHO-2732