Skip to content

feat(statics): onboard CECHO-2732 mon:usdt0 and eth:stampx - #10181

Merged
manojkumar138 merged 1 commit into
masterfrom
feature/CECHO-2732-mon-usdt0-eth-stampx
Nov 16, 2026
Merged

manojkumar138 merged 1 commit into
masterfrom
feature/CECHO-2732-mon-usdt0-eth-stampx

Conversation

@manojkumar138

@manojkumar138 manojkumar138 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

CECHO-2732 — onboard mon:usdt0 and eth:stampx

Adds two client-requested tokens bolted onto the CECHO-2732 ticket (per Rishi's comment, for the OVC and Express releases), following PR #10172 (batch 11/12).

Release Symbol Chain Decimals Contract (verified on-chain)
OVC mon:usdt0 Monad mainnet (chain 143, 0x8f) 6 0xe7cd86e13ac4309349f30b3435a9d337750fc82d
Express eth:stampx Ethereum mainnet (0x1) 18 0xc0aca7acdd9adeed3177a4b299caebe816842f52

Changes

  • base.ts — new UnderlyingAsset entries: mon:usdt0 (Monad mainnet block), eth:stampx.
  • allCoinsAndTokens.ts — monErc20(...) USDT0 entry appended to the MON mainnet tokens.
  • coins/erc20Coins.ts — erc20(...) STAMPx entry appended after eth:spxux.

Details

  • mon:usdt0 — symbol/name read via eth_call (symbol() = USDT0, decimals() = 6) on rpc.monad.xyz; also confirmed as the monad platform entry on CoinGecko (usdt0, live price ~$1).
  • eth:stampx — symbol/decimals read via eth_call on Ethereum mainnet = STAMPx, decimals() = 18 (cross-checked on two independent RPCs: publicnode + drpc). No CoinGecko/CryptoCompare entry exists for STAMPx yet.
  • Gatekeeping: unchanged — these are platform tokens, added ungated (no botTokens.ts/botOfcTokens.ts changes, mirroring PR feat(statics): onboard CECHO-2732 client requested tokens batch (11/12) #10172's approach for ungated platform tokens).

OFC counterparts

Added ofc* tokens for all 8 CECHO-2732 tokens (the 6 from batch 11/12 that shipped in statics 2204, plus the 2 above), following the existing per-chain patterns:

  • ofchoodeth:rlusd (ofcHoodethTokens.ts, ofcerc20, Robinhood fullName convention)
  • ofcxlm:SPXU-… (ofcStellarToken, 7 decimals)
  • ofccanton:beth/usty/exau/exag (ofcCantonToken, 10 decimals)
  • ofcthbar:fly (tofcHederaToken, testnet — fullName Fluency (Testnet) per the OFC naming rule)
  • ofcsol:cash (ofcsolToken, UnderlyingAsset.CASH, 6 decimals, [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN] matching ofcsol:usdc — the underlying sol:cash is a stablecoin)
  • ofcmon:usdt0 (ofcerc20, STABLECOIN feature like ofcmon:usdc)
  • ofceth:stampx (ofcerc20, defaults)

Split out of this PR

  • The modules/key-card/package.json @bitgo/sdk-lib-mpc bump moved to PR #10182 per review feedback. This PR is now statics-only.

Validation

  • tsc --noEmit -p modules/statics — clean.
  • Statics unit tests: 42,050 passing, 0 failing.
  • prettier --check clean on all changed statics files.

Ticket: CECHO-2732

@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

CECHO-2732

@manojkumar138
manojkumar138 marked this pull request as ready for review November 16, 2026 06:43
@manojkumar138
manojkumar138 requested a review from a team as a code owner November 16, 2026 06:43

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 15s —— View job


Review of PR #10181: onboard mon:usdt0 and eth:stampx

I found no blocking issues.

  • Read the diff against origin/master
  • Checked that the new UUIDs, contract addresses and asset names are unique
  • Checked the helper signatures

What I checked

  • Uniqueness: each new UUID, contract address and asset name appears only once in modules/statics/src, so nothing collides with an existing token.
  • Helper usage: monErc20(id, name, fullName, decimals, contract, asset) matches the helper's signature in account.ts. It defaults to the Networks.main.mon network and adds the EIP1559 feature. That fits a mainnet Monad token.
  • Enum entries: UnderlyingAsset['mon:usdt0'] sits in the Monad mainnet block, and 'eth:stampx' sits next to 'eth:spxux'. Both match the existing conventions.
  • Addresses: both contract addresses are lowercase, like the surrounding entries.
  • Decimals: both tokens use 6, as the PR description states.

Minor notes (non-blocking)

  1. I couldn't check the on-chain values (symbol, decimals, contract) from this environment. I'm relying on the PR description for those.
  2. eth:stampx has no CoinGecko or CryptoCompare entry yet, as the description says. If pricing is needed downstream, it will have to be wired up separately.
  3. I didn't run the tests or the build here. I'm relying on the PR's stated results: tsc clean and 42,009 statics tests passing.
  4. The commit footer has to reference CECHO-2732, as commitlint requires. I didn't verify that.

The change is a straightforward additive token onboarding and looks good to merge once CI is green.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

ArunBala-Bitgo
ArunBala-Bitgo previously approved these changes Nov 16, 2026
@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch 2 times, most recently from 73b8905 to f896502 Compare November 16, 2026 07:06
@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 34s —— View job


Review of PR #10181

The new token entries look right. I found one likely bug in ofcsol:cash and some description mismatches. I read the diff but didn't run the build or tests.

Fix before merge

  1. ofcsol:cash features (modules/statics/src/coins/ofcCoins.ts:7084) are [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.REQUIRES_RESERVE].
    • Every other ofcsol:* token uses SOL_OFC_TOKEN_FEATURES, which adds TSS and TSS_COLD. The same tokens add STABLECOIN where it applies.
    • REQUIRES_RESERVE appears nowhere else in ofcCoins.ts.
    • The underlying sol:cash is a stablecoin (solTokens.ts:844).
    • As written, the OFC token drops the TSS flags and the stablecoin flag, and it adds a reserve flag with no precedent.
    • I suggest [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN], matching ofcsol:usdc and ofcsol:usdt. If REQUIRES_RESERVE is intentional, please say why.

Description vs. diff
2. The description says "No OFC counterparts … were not created". It also says OFC counterparts were added for all 8 tokens. The diff has 12 OFC entries: the 8 tokens, with Canton counted as 4. Please remove the stale "No OFC counterparts" line.
3. The validation section says prettier --check was clean on "the three changed files". The PR now changes six.
4. An earlier review comment said both new tokens use 6 decimals. That's wrong. mon:usdt0 is 6 and eth:stampx is 18, and the code matches the description.

Checked and fine

  • All 12 new UUIDs appear exactly once in the repo.
  • The ofcmon:usdt0 entry mirrors ofcmon:usdc. It uses the MON: name prefix, the STABLECOIN feature, and the 'mon' network argument.
  • The ofcthbar:fly entry has 18 decimals, matching thbar:fly.
  • The ofchoodeth:rlusd entry has 18 decimals, matching hoodeth:rlusd.
  • The enum entries and the monErc20 and erc20 calls are correctly placed. Contract addresses are lowercase.

Not verified

  • I couldn't check the on-chain symbol, decimals or contract addresses from here. I'm relying on the description for those.
  • I didn't check that the commit footer references CECHO-2732. The commit message ends with Ticket: CECHO-2732, and I didn't compare that against commitlint.config.js.

@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch from f896502 to 8369279 Compare November 16, 2026 07:10
@manojkumar138
manojkumar138 requested a review from a team as a code owner November 16, 2026 07:10
@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 18s —— View job


Review of PR #10181

The token and OFC entries look correct, apart from the features on ofcsol:cash. I read the diff and compared it with neighbouring entries. I didn't run the build or tests.

Fix before merge

  1. ofcsol:cash features (modules/statics/src/coins/ofcCoins.ts:7084) are [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.REQUIRES_RESERVE].
    • Other ofcsol:* tokens use SOL_OFC_TOKEN_FEATURES, and stablecoins add STABLECOIN. ofcsol:usdc is an example.
    • REQUIRES_RESERVE appears nowhere else in ofcCoins.ts.
    • The underlying sol:cash is [...SOL_TOKEN_FEATURES, CoinFeature.STABLECOIN] (solTokens.ts:845).
    • I suggest [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN]. If REQUIRES_RESERVE is intentional, please say why in the PR.

Description cleanup
2. The PR body still says "No OFC counterparts … were not created", and a later section says they were added. Please remove the stale line.
3. The validation section says prettier --check was clean on "the three changed files". The PR now changes seven.

Checked and fine

  • ofcmon:usdt0 mirrors the ofcmon:usdc pattern: MON: name prefix, STABLECOIN feature, 'mon' network.
  • ofchoodeth:rlusd and ofcthbar:fly use 18 decimals, and ofceth:stampx uses 18. ofcxlm:SPXU uses 7 and the Canton tokens use 10.
  • The Stellar and Canton entries sit next to their sibling OFC tokens.
  • The key-card bump to @bitgo/sdk-lib-mpc ^11.6.1 is a one-line change.

Not verified

  • On-chain symbol, decimals and contract addresses. I'm relying on the PR description for these.
  • Commit footer against commitlint. The commit ends with Ticket: CECHO-2732.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline finding, I checked two other things and ruled them out. ofcmon:usdt0 sits in the testnet tOfcErc20Coins array but points to the mainnet mon:usdt0. The existing ofcmon:usdc and ofcmon:wmon sit in that same array, so this placement follows the existing pattern. The wider account-coin feature set on ofcsol:cash was also examined and not raised as a bug.

Extended reasoning...

The change adds coin-registry data only to @ bitgo/statics: two UnderlyingAsset enum values, two base tokens, and eight new OFC entries. It touches no auth, crypto or permission code. The note covers only placement and feature-set checks that no earlier review body on this PR covered.

Comment thread modules/statics/src/coins/ofcCoins.ts Resolved
@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch from 8369279 to 2e86140 Compare November 16, 2026 07:21
@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude re-review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline finding, I also looked at ofcmon:usdt0 sitting inside tOfcErc20Coins. It is not a problem: ofcerc20 sets the network to mainnet OFC on its own, and the existing mainnet entries ofcmon:usdc and ofcmon:wmon live in the same array.

Extended reasoning...

The PR adds static token definitions to @ bitgo/statics (new UnderlyingAsset entries, ERC20, Monad and OFC tokens) and bumps one devDependency in key-card. The only thing this note rules out is the testnet-array placement. The network for ofcerc20 comes from its default parameter (Networks.main.ofc in ofc.ts), not from which array the entry is in.

Still open from earlier reviews (1):

  • Unresolved: 1 minor or pre-existing.

Comment thread modules/statics/src/coins/ofcCoins.ts Resolved
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 21s —— View job


Re-review of PR #10181

The only open item is a small optional one: ofchoodeth:rlusd isn't flagged as a stablecoin. I read the diff and compared it with neighbouring entries. I didn't run the build or tests.

Resolved since the last review

  • ofcsol:cash now uses [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN]. That matches ofcsol:usdc and the base sol:cash, and REQUIRES_RESERVE is gone.
  • ofcmon:usdt0 mirrors ofcmon:usdc: MON: prefix, STABLECOIN feature, 'mon' network.

Optional

  1. ofchoodeth:rlusd has no STABLECOIN feature (modules/statics/src/coins/ofcHoodethTokens.ts, new entry). It passes undefined for features, so it gets the OFC defaults.
    • The base hoodeth:rlusd (hoodethTokens.ts:3075) includes STABLECOIN.
    • Other OFC stablecoins set it, for example ofcxrp:rlusd, ofcsol:usdc and ofcmon:usdt0.
    • Anything that filters OFC assets by CoinFeature.STABLECOIN will miss this token.
    • No other entry in ofcHoodethTokens.ts sets STABLECOIN, so this is only a consistency suggestion.
    • Suggested fix: pass [...OfcCoin.DEFAULT_FEATURES, CoinFeature.STABLECOIN] as the features argument, as ofcmon:usdt0 does.

Not verified

  • On-chain symbol, decimals and contract addresses. I'm relying on the PR description for these.
  • Test and build results. I'm relying on the PR's stated results.

Nothing else blocks merge.

@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch from 2e86140 to a36d602 Compare November 16, 2026 07:28
@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude re-review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 20s —— View job


Re-review of PR #10181

There is one blocker: the commit deletes the existing ofcxlm:btgo coin. I read the commit diff and compared it with neighbouring entries. I couldn't run the build or tests, so I didn't run the Stellar entry through them.

Fix before merge

  1. ofcxlm:btgo is removed by accident (modules/statics/src/coins/ofcCoins.ts, around line 5059).
    • The new ofcxlm:SPXU-… entry was written over the existing ofcxlm:btgo entry instead of being inserted next to it.
    • The diff removes bebecdfe-0a09-4e43-be91-62afdbe2ce49 / ofcxlm:btgo / BTGO / UnderlyingAsset['xlm:BTGO-GAXTPUVP…']. That is the 4 removed lines plus the edited ofcStellarToken( call. A grep of modules/ for that UUID and for ofcxlm:btgo now finds nothing.
    • This is a production OFC coin and it would disappear from statics. That is also why the PR shows 5 deletions for what should be a purely additive change.
    • Fix: restore the ofcxlm:btgo entry unchanged. Then add the ofcxlm:SPXU-… entry after it as a separate call.

Resolved since the last review

  • ofcsol:cash now uses [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN].
  • ofcxlm:SPXU-… now passes ACCOUNT_COIN_DEFAULT_FEATURES_TRUST_ONLY explicitly. It is also added to the 'WTGXX Trust-only custody' test. This fixes the case-sensitive getFilteredFeatures lookup problem flagged earlier.

Optional (still open)
2. ofchoodeth:rlusd has no STABLECOIN feature (ofcHoodethTokens.ts, new entry). It passes undefined for features, but the base hoodeth:rlusd includes STABLECOIN. Pass [...OfcCoin.DEFAULT_FEATURES, CoinFeature.STABLECOIN], as ofcmon:usdt0 does.

Checked and fine

  • ofcmon:usdt0 mirrors ofcmon:usdc. It uses the MON: prefix, STABLECOIN, and the 'mon' network.
  • The four Canton entries use 10 decimals and ofcthbar:fly uses 18, matching their base tokens.

Not verified

  • On-chain symbol, decimals and contract addresses. I'm relying on the PR description for these.
  • Test and build results. I'm relying on the PR's stated results.

@manojkumar138
manojkumar138 marked this pull request as draft November 16, 2026 07:35
@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch from a36d602 to e91e314 Compare November 16, 2026 07:39
@manojkumar138

Copy link
Copy Markdown
Contributor Author

Addressed the re-review findings (amended commit e91e314):

1. Blocker — ofcxlm:btgo deleted: fixed. You were right, the new Stellar entry had been written over the existing bebecdfe-0a09-4e43-be91-62afdbe2ce49 / ofcxlm:btgo / xlm:BTGO-GAXTPUVP… call. Restored it verbatim from master and added ofcxlm:SPXU-… as a separate call right after it. git diff origin/master --numstat on ofcCoins.ts is now 53 insertions, 0 deletions — the change is purely additive again.

2. Optional — ofchoodeth:rlusd STABLECOIN: no change needed. ofcerc20 derives suffix = HOODETH:RLUSD and getFilteredFeatures lowercases it before the CoinMap.has lookup, so it matches the base hoodeth:rlusd and inherits its features, STABLECOIN included. Confirmed by instantiating the coin: coins.get('ofchoodeth:rlusd').features includes STABLECOIN. (That inheritance also overrides any explicit features argument, so passing one would be a no-op here.)

Worth noting for the record: by the same mechanism ofcmon:usdt0 resolves to STABLECOIN=false despite the explicit argument, because base mon:usdt0 has no STABLECOIN flag — consistent with mantle:usdt0 and inketh:usdt0, so left unchanged.

Validation on the amended commit

  • tsc --noEmit -p modules/statics — clean.
  • Statics unit tests: 42,050 passing, 0 failing.
  • prettier --check modules/statics/src/coins/ofcCoins.ts — clean.

@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude re-review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 17s —— View job


Re-review of PR #10181

I found no blocking issues. I read the amended commit e91e314 and didn't run the build or tests.

Resolved since the last review

  • ofcxlm:btgo: the existing entry is no longer touched. ofcCoins.ts is purely additive, and the commit stat is 108 insertions and 1 deletion (the key-card version bump).
  • ofcxlm:SPXU-…: it now passes ACCOUNT_COIN_DEFAULT_FEATURES_TRUST_ONLY explicitly. It is also in the 'WTGXX Trust-only custody' test list.
  • ofcsol:cash: it uses [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN], which matches ofcsol:usdc.
  • ofchoodeth:rlusd STABLECOIN: your explanation is plausible. ofcerc20 derives the suffix HOODETH:RLUSD, which lowercases to match the base token and inherits its features. I didn't re-run your instantiation check.
  • ofcmon:usdt0 STABLECOIN: inheriting from base mon:usdt0 is consistent with the other USDT0 chains. Its explicit STABLECOIN argument has no effect, so you could drop it for clarity. This is optional.

Checked and fine

  • The decimals are correct: 6 for mon:usdt0, 18 for eth:stampx, ofchoodeth:rlusd and ofcthbar:fly, 7 for the Stellar token, and 10 for the Canton tokens.
  • The Robinhood and (Testnet) name conventions are followed.
  • The ofcsol:cash entry uses UnderlyingAsset.CASH.

Not verified

  • On-chain values. I'm relying on the description for those.
  • Test and build results. I'm relying on your stated results: tsc clean, 42,050 statics tests passing, and prettier clean.

The PR looks good to merge once CI is green.

@manojkumar138
manojkumar138 marked this pull request as ready for review November 16, 2026 07:42
Comment thread modules/key-card/package.json Resolved
@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch 2 times, most recently from 6cea9ed to 57bc524 Compare November 16, 2026 08:02
…ounterparts

Adds two client-requested tokens for the CECHO-2732 ticket's OVC and
Express releases, plus OFC counterparts for all ticket tokens:
- mon:usdt0 (USDT0) on Monad mainnet: 6 decimals,
  0xe7cd86e13ac4309349f30b3435a9d337750fc82d (symbol/decimals verified
  on-chain via eth_call on rpc.monad.xyz)
- eth:stampx (STAMPx) on Ethereum mainnet: 18 decimals,
  0xc0aca7acdd9adeed3177a4b299caebe816842f52 (symbol/decimals verified
  on-chain via eth_call; note 18, not the 6 typical of wrapped assets)

OFC counterparts added for all 8 CECHO-2732 tokens (the 6 from batch
11/12 plus these two):
- ofchoodeth:rlusd (ofcHoodethTokens.ts)
- ofcxlm:SPXU-... (ofcStellarToken, ACCOUNT_COIN_DEFAULT_FEATURES_TRUST_ONLY
  to mirror the base token's Trust-only custody; the mixed-case Stellar
  name never matches getFilteredFeatures' lowercase lookup, so the
  features must be passed explicitly)
- ofccanton:beth/usty/exau/exag (ofcCantonToken)
- ofcthbar:fly (tofcHederaToken, 'Fluency (Testnet)' per naming rule)
- ofcsol:cash (ofcsolToken, UnderlyingAsset.CASH, 6 decimals,
  [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN] matching
  ofcsol:usdc; the underlying sol:cash is a stablecoin)
- ofcmon:usdt0, ofceth:stampx (ofcerc20, STABLECOIN on usdt0)

ofcxlm:SPXU-... is added to the 'WTGXX Trust-only custody' test to
lock the behavior in.

USDT0 is priced on CoinGecko (live, $1 pegged); STAMPx has no
CryptoCompare pricing yet.

Ticket: CECHO-2732
@manojkumar138
manojkumar138 force-pushed the feature/CECHO-2732-mon-usdt0-eth-stampx branch from 57bc524 to d676f7d Compare November 16, 2026 09:14
@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude re-review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 21s —— View job


Re-review of PR #10181

I found no blocking issues. I read the diff against origin/master (now d676f7d, statics only) and ran a few greps. I didn't run the build or tests.

Checked

  • Scope: 7 files, +107/-0, purely additive. The key-card bump is gone (moved to fix(key-card): bump @bitgo/sdk-lib-mpc devDependency to ^11.6.1 #10182), and ofcxlm:btgo is untouched.
  • UUIDs: all 12 new UUIDs appear exactly once in modules/statics/src.
  • Underlying assets: UnderlyingAsset has entries for hoodeth:rlusd, thbar:fly, canton:beth, canton:usty, canton:exau, canton:exag and CASH. The new mon:usdt0 and eth:stampx are added in this PR.
  • mon:usdt0: it uses monErc20, with 6 decimals and a lowercase contract address.
  • eth:stampx: it uses erc20, with 18 decimals and a lowercase contract address. The OFC counterpart also has 18.
  • ofcxlm:SPXU-…: it passes ACCOUNT_COIN_DEFAULT_FEATURES_TRUST_ONLY explicitly and is in the 'WTGXX Trust-only custody' test list. That covers the earlier case-sensitive lookup issue.
  • ofcsol:cash: it uses [...SOL_OFC_TOKEN_FEATURES, CoinFeature.STABLECOIN].
  • Other OFC entries: the Canton tokens use 10 decimals, ofcthbar:fly uses 18 with the (Testnet) name, and ofchoodeth:rlusd follows the Robinhood naming.

Optional nit

  • ofcmon:usdt0 passes [...OfcCoin.DEFAULT_FEATURES, CoinFeature.STABLECOIN]. You said this is overridden by the inherited base features, so the argument has no effect. You could drop it for clarity. It's harmless, and it matches ofcmon:usdc.

Not verified

  • On-chain symbol, decimals and contract addresses. I'm relying on the description for these.
  • Test and build results. I'm relying on your stated results: tsc clean and 42,050 statics tests passing.

The PR looks good to merge once CI is green.

@rithwik-bitgo rithwik-bitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojkumar138
manojkumar138 merged commit 00045ca into master Nov 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants