Repository navigation
Description
Context
Solana v1 (SIMD-0296/0385) has three vestigial artifacts left over from the abandoned
"client-supplied v1 envelope" design. They are unreachable from Wallet Platform and only
survive as public SDK surface + their own tests.
Wallet Platform has rejected v1 envelopes since 2026-10-19
(bitgo-microservices f038790f0a2, app/controllers/api/v2/coins/sol/sol.ts):
if (isV1CustomTxIntent(intent)) {
throw new ApiError.Invalid(
'v1 customTx envelopes are not supported: send a structured v1 payment intent',
);
}and before that rejection the route validated the envelope and threw
'v1 transaction build/submit not yet supported' — so no client ever got a v1 wire
built from a customTx envelope.
What is dead
modules/sdk-coin-sol/src/lib/v1CustomInstructionBuilder.ts—V1CustomInstructionBuilder
(reachable only viaTransactionBuilderFactory.getV1CustomInstructionBuilder(), with no
Wallet Platform caller).version?: 0 | 1andtransactionConfig?insideSolVersionedTransactionData
(modules/sdk-core/src/bitgo/wallet/iWallet.ts, the envelope shape) — only consumed by the
v1 branch ofV1TransactionBuilder.fromVersionedData/buildFromVersionedData.- The v1 branches in
V1TransactionBuilder(fromImplementation,buildV1) that exist
solely to serve that envelope shape.
Envelope support itself (v0 + address lookup tables) MUST stay — it is the shipped
customTx/ALT feature.
Pre-check before deleting
Grep production/staging Wallet Platform logs for the two error strings
(v1 customTx envelopes are not supported, v1 transaction build/submit not yet supported)
across the last few weeks. If any client hit them, notify them first; if nobody did, delete.
Scope
- remove
V1CustomInstructionBuilder+getV1CustomInstructionBuilder - remove the envelope-level
version/transactionConfigfields from
SolVersionedTransactionData(public-types side too, if it declares them) - remove the corresponding unit tests (
test/unit/transactionBuilder/v1TransactionBuilder.ts
v1-custom cases), keep the v1 payment/confidential-transfer coverage - keep
V1TransactionBuilderas the shared base forV1PaymentBuilderand
ConfidentialTransferBuilder
Acceptance
grep -r "V1CustomInstructionBuilder\|getV1CustomInstructionBuilder"returns nothingsdk-coin-solsuite green, no change in v1 payment / CT wire output- JSDoc on the structured path documents
version: 1on the intent as the only v1 entry point
Refs: CHALO-1603 (v1 activation), CHALO-1758 (v1 build+submit).
Activity