Repository navigation
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NeoForge tick can remove a reward task from the queue just before shutdown drains it. That selected task could still execute after close, or be rejected only after replay/storage teardown and leave a durable uncertainty fence despite no reward having run.
Keep scheduler ownership after dequeue and reject every unstarted task during close, before replay and storage stop. Serialize active task execution with close, preserve reentrant scheduler shutdown, and finish late callback registration on the replay worker when shutdown rejects another dispatch. Aggregate completed replay results without requiring a new executor task after shutdown.
This is limited to NeoForge scheduler/replay lifecycle handling. Configuration, commands, dependencies, storage formats, transport protocols and other platform code are unchanged. A never-started reward retains its original pending vote ID and can replay after restart; accounting and completion receipts still fence duplicate processing. Existing uncertainty handling for an action that may have executed is retained.
Validation at
4d99e8e2b0a4dc57e576cabbfcc7507bec2deaeb: 67 focused tests pass; clean Maven package passes 3,375 unit tests (one skip) and eight artifact checks, with zero failures/errors. Regressions cover deterministic dequeue-before-close cancellation, multiple selected/queued tasks, full runtime shutdown before tick resumption, late callback registration, reentrant close, SQLite restart replay and one accounting completion across subsequent restart. The original scheduler test failed before the fix; the full-shutdown regression also reproduced the first implementation's late-rejection defect, now corrected. Fresh independent full source/disclosure review reports no findings.Fresh JAR SHA-256:
a5a6594bc0f20ec86eeb532eb0ac72084aa70d7da7ea09f218036487e1da0817; 11,129,167 bytes, above the advisory 10 MiB target. Tests use JVM scheduler seams, real SQLite and injected actions. Native NeoForge/server/proxy acceptance has not run and remains separate. Exact-head hosted Maven and CodeQL checks pass. Hosted CodeRabbit review was rate-limited; its neutral status is not a completed review.