Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling one plugin previously shut down the static metrics scheduler shared by other owners and could prevent later initialization. Give each metrics instance its own executor, retire only the matching owner on Bukkit disable, and preserve construction before enable and when metrics are opted out. Reporting intervals, service identifiers and payloads remain unchanged.
Handle rejected platform handoffs, delayed callbacks after retirement and partial initialization without retiring siblings or leaking an idle executor. Adds an explicit
MetricsBase.shutdown()for direct consumers.Validation for commit
01168e12dcf2d9bd0de3d8c5cc8b957d1db4370b:No live Bukkit-family server acceptance was performed. This draft is separate from YAML API and nested configuration changes.