Skip to content

Add manual validation for pinned PR383 source - #388

Closed
BenCodez wants to merge 1 commit into
masterfrom
ci/validate-pr383-exact-head
Closed

BenCodez wants to merge 1 commit into
masterfrom
ci/validate-pr383-exact-head

Conversation

@BenCodez

@BenCodez BenCodez commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Adds a manual Java 21 package validation route for source revision c9a52e3 without retargeting PR #383.

The job runs only when manually dispatched from master. It uses pinned checkout/setup actions, read-only contents permission, no persisted checkout credentials, no deployment secrets, no Maven cache and no artifact upload. It verifies the source revision, both test executions (2,157 ordinary and 2 packaged cases), shaded JAR/POM hashes, compiler paths and resolved/test dependency identities.

Validation: exact workflow source independently reviewed; embedded Python and shell syntax checked; plain/module-annotated dependency paths and invalid-path controls checked. No application changes or local application/consumer rebuild. The hosted manual job has not run.

Merge and manual dispatch remain separate approval steps. A successful run establishes a new tested dependency tuple; it does not resolve outstanding PR #383 findings or authorize snapshot deployment. Dependency reconciliation, affected downstream evidence and existing review/check gates remain required.

Summary by CodeRabbit

  • Chores
    • Added a manually triggered validation workflow for the master branch. It builds the project with Java 21 and reports test results, package details, and dependency information.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Adds a manually triggered, master-ref-only workflow that builds a pinned AdvancedCore revision with Java 21. The workflow checks source state, dependency data, test reports, classpaths, and artifact hashes.

Changes: Pinned Build Validation

Layer / File(s) Summary
Build and verify pinned revision
.github/workflows/validate-pr383.yml
The workflow checks out a fixed commit with read-only permissions, verifies the source state, and runs Maven packaging and dependency listing. It then checks the packaged JAR, dependency graph, test totals, execution classpaths, compiler search-path evidence, and resolved artifact hashes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: Minimal · up to 31b9a

This PR adds a manual validation workflow and does not change application behavior. Its restricted triggers and permissions make it low-risk to merge. The hosted run still needs to be dispatched separately to produce evidence.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Add manual validation for pinned PR383 source" matches the main change. The PR adds a manually dispatched workflow that checks out a fixed commit of the source, runs Java 21 Maven package a…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Add manual validation for pinned PR383 source" matches the main change. The PR adds a manually dispatched workflow that checks out a fixed commit of the source, runs Java 21 Maven package and test steps, and validates JAR and dependency hashes. The title names the pinned source and the manual validation route. It does not name the Maven build or the dependency and hash checks, but it does not mislead.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 595f374b-bdfc-43a5-8108-dc36723403e6
Commits

Reviewing files that changed from the base of the PR and between 5d14329 and 31b9ae2.

Files selected for processing: 1

  • .github/workflows/validate-pr383.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 4

  • GitHub Check: CodeRabbit
  • GitHub Check: build
  • GitHub Check: Analyze (java-kotlin)
  • GitHub Check: Analyze (actions)
Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered
Path-based instructions: 1

Source excerpt: AdvancedCore is a shared Bukkit/Paper/Folia library embedded by plugins such as VotingPlugin, MCPerks, and GraveStonesPlus.

CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/workflows/validate-pr383.yml
Additional comments: 1

.github/workflows/validate-pr383.yml: 1

1-87: LGTM!

@BenCodez BenCodez closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants