Repository navigation
Add CSS Grid Layout Standard snippets #19
Description
BeastCode,
Still missing ng-cong? me too!
Now that css grid layout has been adopted by Mozilla and Chrome, would be nice to have some snips.
-MB
{{ message }}
BeastCode,
Still missing ng-cong? me too!
Now that css grid layout has been adopted by Mozilla and Chrome, would be nice to have some snips.
-MB
Activity
cgatian commentedon Sep 14, 2017
@BeastCode these type of snippets feel add-on. Perhaps they are a separate package, or use a different prefix?
I guess the bottom line is what does the OP want? Examples? Css grid is dynamic and creating a useful one snip fits all is going to be quite hard.
My suggestion is, while we are refactoring the snippets for Angular 5, we place examples (if that's what the OP intended) in a new prefix, 'example--'. Given this syntax, the OP would find his grid example with 'example-css-grid-layout'
Thoughts?
cgatian commentedon Sep 14, 2017
Downside to this is you don't have example snippets directly accessible from the real snips. ( Like for ng-pipe, ng-pipe-example). But, I think it actually might clean up the intellisense and provide a nice separation. Users typically know they are looking for the example when they need it. It's not something they decide when navigating the snippet intellisense.
Following this idea through, the pipe example snip would be renamed to:
example-ng-pipe
BeastCode commentedon Sep 17, 2017
How should we group examples?
ng-example-
m-example-
ng-example-pipe
or
example-ng
example-m
example-ng-pipe
cgatian commentedon Sep 17, 2017
Doing
mat-feels like a natural namespace.So Im taking myself back, and I think we should do
mat-example-<type>. But at the same time maybe you had it right the whole time!mat-pipe-example... Gosh its pretty explicit... Im coming around to your original syntax.cgatian commentedon Sep 17, 2017
No I like what you did there. I think doing
example-ng-pipeis wrong.BeastCode commentedon Sep 17, 2017
I went trough the same thoughts when I created the first example snippet. But I do see a point grouping all angular examples ng-example- but at this point there's not many examples///