Repository navigation
test(completion): trace a missing snippet selection - #149
Draft
BartvHelvert wants to merge 1 commit into
Draft
BartvHelvert wants to merge 1 commit into
BartvHelvert wants to merge 1 commit into
Conversation
This was referenced Nov 10, 2026
A single completion request can succeed without leaving the first placeholder selected. Capture text and selection in both processes, trace template state, and retain a failure hierarchy to distinguish a missing insert from a lost template selection. Refs #146
BartvHelvert
force-pushed
the
test/snippet-selection
branch
from
November 10, 2026 19:54
1dd8913 to
7581e50
Compare
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Investigation of #146, rebased onto master and reduced to the test it belongs to.
SplitModeSnippetsTestrecords the client's text and selection together with the backend editor'stext and selection on each observation, traces the platform's template state in both IDEs, and
keeps a UI hierarchy if the scenario fails. The existing checks for typing and Tab navigation stay,
and insertion is still performed once.
Refs #146
What changed since it was opened
The
repeat_ui_testworkflow commit is gone from this branch. It was duplicated with #150,differing only in the hard-coded test class, so it is being landed once on its own, generalised to
take the class as a workflow input. Repeats of this class will be dispatched with that instead.
Its batch found a failure, but not this one. The twenty jobs on
1dd8913dproduced one, inwindows-2025 repeat 8/10:[first, PROBE Widgetbody {, , }]— theTabbetween theplaceholder and the body did nothing, so the body text landed on the end of the placeholder. That
is a different step from this PR's, it was diagnosed by the pre-existing assertion rather than by
the diagnostics added here, and it has its own cause: a key press discarded while the IDE waits on
a lock. Filed as #153 and fixed in #152.
#146 itself did not reproduce in twenty runs and is still unexplained. Its distinguishing fact
stands: insertion provably succeeded —
CompletionFinished(reason=SUCCEEDED), client insertionlogged — and the placeholder still never appeared selected. Nothing found since accounts for that,
and the lost-keystroke mechanism does not: a discarded Enter would have meant no insertion at all.
So the sampling added here is still aimed at the open question, which is whether the text failed to
expand or the selection was lost after it did.
What to do with it
Draft, and still worth keeping drafted. Next step is another twenty or thirty repeats through the
extracted harness, once that lands. If #146 will not reproduce, close this and leave the issue open
with what is known; the diagnostics can come back when it next fires.
How it was tested
:ui-test:compileTestKotlinpasses after the rebase.Checklist
A new feature has a UI test.Diagnostics in an existing UI test.names are log categories only; remote reads use public
EditorandSelectionModelAPI.Investigation only.docs/is updated where behaviour changed,docs/status.mdespecially.Third-party material keeps its notice and is listed inNone added.NOTICE.md.