Repository navigation
Commit the recovered probability-branch ensemble memory frontier - #280
Open
Alexander-Mitrofanov wants to merge 1 commit into
Open
Alexander-Mitrofanov wants to merge 1 commit into
Alexander-Mitrofanov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This promotes the validation-only forward port of PR #261 onto the current base-pair probability branch. Seed-extension predictions group partial site partitions by their target right boundary, finalize buckets once no remaining seed can contribute to them, and release that storage. Keys retain three coordinates because the bucket supplies the fourth.
The seed-handler order and partition contribution order are preserved. A suffix minimum of seed starts makes finalization safe for non-monotonic explicit seed iteration. Tracker-enabled runs retain the deferred map and callback order. Reuse and empty-region initialization reset the frontier. The canonical exact stack-seed kernel and its reverse pair-probability computation are unchanged; legacy exact seeded extension and heuristic extension use the recovered frontier. Direct container/hash includes make the changed public header self-contained.
Why it was not committed before: the implementation lived in
issue-260-validation/feat-fixedas an integration-validation port. PR #261 intentionally targeted master and supplied the forward port asdoc/ensemble-memory-probability-port.patchrather than committing it to the probability branch. The validation tree also contained SVG changes later committed in PR #259; those already exist in this PR's base and are not duplicated. This PR commits the six-file memory port, its existing streamed-versus-buffered regressions, a provenance note and ChangeLog.This PR is stacked on #279, which aligns existing tests with the probability branch's later debug-only precondition checks. Review that test-only change first; the diff here contains the recovered optimization and its documentation. The historical artifacts are separately preserved in #278, and the C++23 audit in #277.
Validation on the assembled series with GCC 14.4 and Kokkos mdspan:
make tests -j2: 7/7 suites, 101,251 assertions in 98 API cases.make tests -j2: 7/7 suites, 101,267 assertions in 98 API cases.Historical measurements and limitations are documented in PR #261. No new general speedup claim is made; Apple Clang and multiprecision validation were not run locally.
Related: #260, #261, #258.