Repository navigation
Continue hashing through short stream reads - #679
Merged
Merged
Conversation
Read nonempty short chunks until the requested length or end of stream. Append the digest only after end of stream and preserve zero-length reads. Fixes #654
|
Warning Review limit reachedThis organization requires a seat for paid usage-based reviews, including automatic and on-demand reviews. Ask an admin to assign a seat or enable paid usage-based reviews for users without a seat in Billing. Next included review available in 43 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A source that returns fewer bytes than requested before the real end of data could make the checksum and length cover only a prefix, so a truncated body could be uploaded with a matching hash. This continues reading until the requested length or the true end of data.
Changes
stream/hashing.py: read until the requested length or true EOF instead of treating a short read as EOF.utils/__init__.py: align the shared helper with the same behavior.Verification
python -m pytest test/unit— full matrix green (v3 1008, v2 1013, v1 1086, v0 926)Closes #654