Skip to content

ci: replace unverified third-party GitHub Actions with first-party steps - #675

Merged
ffumero2003 merged 2 commits into
masterfrom
ci-vendor-third-party-actions
Nov 19, 2026
Merged

ffumero2003 merged 2 commits into
masterfrom
ci-vendor-third-party-actions

Conversation

@ffumero2003

Copy link
Copy Markdown
Contributor

Context

Part of the organization-wide GitHub Actions governance effort: actions owned by individual developers or unverified vendors should not run in our CI/CD. This replaces each such action with a first-party step we control. GitHub-official and verified-vendor actions (including the PyPI publish) are unchanged.

Changes

  • softprops/action-gh-release (cd.yml) → gh release create/upload, preserving the tag, title, notes, and assets.
  • mindsers/changelog-reader-action (cd.yml) → a local changelog extraction step producing byte-for-byte identical output.
  • codespell-project/actions-codespell (ci.yml) → an inline pipx run codespell reproducing the original action's exact invocation and result.
  • Each original action block is retained commented-out as an instant fallback, pending a verified real run.

Verification

  • Changelog extraction: byte-exact across multiple versions (2.13.5/2.13.4/2.13.3).
  • Release command routing: verified across stub cases.
  • codespell: the inline step reproduces the original exactly — the original passed a space-separated ignore list (datas re-use), which codespell interprets as ignore word datas plus a positional path re-use, so master's codespell scanned effectively nothing and exited 0. The replacement matches that (exit 0, no findings). Fixing the codespell invocation and the repository's real typos is intentionally left to a separate spelling-only change.
  • actionlint passes for both workflows; no unrelated steps were changed.
  • Not verified until a real run: the live GitHub release publish only runs at a tagged release; the commented-out originals remain as a fallback until that first release is green.

Closes #674

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI and CD workflows replace third-party actions with local commands. The CD workflow grants the deploy job contents: write, adjusts prerelease output handling, extracts changelog notes for an exact version heading, and uses gh commands to manage releases and matching assets. The CI lint job runs codespell through pipx. A changelog entry documents the replacements and commented fallbacks.

Merge Risk: Minimal · up to 1b11c

The change replaces three third-party workflow actions with first-party commands. No merge-blocking issue was found. The release path has not been run against a real tagged release, so the first release run should be watched.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: replacing third-party GitHub Actions with first-party workflow steps. The changeset matches this. The title follows the conventional commit style and is specific enoug…
Description check Passed The description explains the governance context and lists each action replaced with its first-party step. It also covers verification and the items not yet verified. It matches the changeset closely.
Linked Issues check Passed [#674] Four coding requirements map to changes at head 1b11c1e.

1. softprops/action-gh-release: cd.yml now runs gh release create (when the tag has no release), gh release upload --clobber (for a…
Out of Scope Changes check Passed The whole-PR diff (merge base 862ab89 to head 1b11c1e) touches only .github/workflows/ci.yml, .github/workflows/cd.yml, and one changelog fragment, as the issue scope requires. Changes in cd.yml are: …
Full details: Title check

Explanation

The title names the main change: replacing third-party GitHub Actions with first-party workflow steps. The changeset matches this. The title follows the conventional commit style and is specific enough for a teammate to understand the primary change.

Full details: Linked Issues check

Explanation

[#674] Four coding requirements map to changes at head 1b11c1e.

  1. softprops/action-gh-release: cd.yml now runs gh release create (when the tag has no release), gh release upload --clobber (for assets matched by ASSET_PATH), and gh release edit to set title, notes, draft, and prerelease. Tag, title, notes, and assets are preserved. The original block is commented out.
  2. mindsers/changelog-reader-action: cd.yml extracts the CHANGELOG.md section with awk. It matches the heading version exactly, trims trailing blank lines, and fails when no heading matches. The output is written to the changes step output. The original block is commented out. Byte-for-byte identity is the author's reported result (versions 2.13.5, 2.13.4, 2.13.3). I did not re-run the extraction, so this rests on the author's verification.
  3. codespell-project/actions-codespell: ci.yml runs pipx run codespell --count --skip ./.git --ignore-words-list datas re-use. This keeps the original ignore list and the positional path, as the PR describes. The original block is commented out. I did not run codespell or confirm the original action's exact arguments.
  4. actionlint: the author reports that it passes for both workflows. I did not run actionlint. The YAML structure in the diff is consistent with valid workflow syntax.

The PyPI publish step is unchanged. The changes add no action steps beyond the three replaced ones.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff (merge base 862ab89 to head 1b11c1e) touches only .github/workflows/ci.yml, .github/workflows/cd.yml, and one changelog fragment, as the issue scope requires. Changes in cd.yml are: the job-level permissions: contents: write (needed for gh release commands; no top-level permissions block exists, so nothing else is overridden), quoting and export changes to the prerelease step, and the three action replacements. The PyPI publish step, its condition, and library code are unchanged. The codespell invocation is preserved and the repository typos are not fixed, as the issue requires. No unrelated change was found.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b45062af-770c-47c4-b4c8-578adfa0a0f9
Commits

Reviewing files that changed from the base of the PR and between 862ab89 and 1b11c1e.

Files selected for processing: 3

  • .github/workflows/cd.yml
  • .github/workflows/ci.yml
  • changelog.d/+ci-vendor-third-party-actions.infrastructure.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@goanpeca goanpeca left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #675 (head 1b11c1e8, closes #674)

Approve after the failed CI job is re-run, and once the overlap with #672 is decided. Two independent reviews (Claude and Codex) found nothing wrong with the code. The PR replaces all three actions and keeps their behavior.

Verified

  • Changelog notes: the new step's output is byte-identical to the published release notes for 2.13.5, 2.13.4, 2.13.3 and 2.13.0, and a version that isn't in the changelog fails the step. 2.10.4 differs only by two leading blank lines that are in the changelog itself.
  • GitHub release: with a stubbed gh, new and existing releases, drafts and pre-releases all go through the right commands. Assets are uploaded before a new release is published, and re-runs are safe (--clobber). The new contents: write permission is enough.
  • codespell: the new step passes the same arguments as the old action. The old action split datas re-use on the space, so re-use became the path to scan and the repo was never checked. The PR keeps this on purpose, as #674 requires.
  • Workflow syntax: actionlint passes on both workflows.
  • CI: the only failure is cli-compat (ubuntu-latest, 3.14), where a CLI integration test got Too many requests from live B2. It's unrelated to this PR; re-run it.

Findings

Severity Where Finding
Process #672 #672 (same author, open) replaces the same three actions and rewrites the same lines in cd.yml and ci.yml. Pick one: merge #675 and rebase #672 on it, or close #675 as superseded.
Nit ci.yml pipx run codespell installs the latest codespell on each run. Pin a version, for example codespell==2.4.1.
Nit cd.yml, ci.yml Open an issue to remove the commented-out original steps after the first real release.
Pre-existing ci.yml Spell checking has effectively been off, and a real scan finds typos (strat, varius). Make sure the separate fix (or #672) lands.

Not verified

The live tagged-release path, from creating the GitHub release to the PyPI upload, can't be tested before a real release. Watch the first tagged release run. The PR says this too.

@ffumero2003
ffumero2003 merged commit afb0a7d into master Nov 19, 2026
53 of 54 checks passed
@ffumero2003
ffumero2003 deleted the ci-vendor-third-party-actions branch November 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: replace unverified third-party GitHub Actions with first-party steps

2 participants