Repository navigation
Azure Service Fabric based new provider implementation. - #307
Merged
Merged
Conversation
* Add Integration Tests. * Integrate with DTFx controllers.
Create Register method.
Listen for `ClientDisconnected` event. Merge both the event sources into single one.
…ithout local caching.
Refactor Event Source.
#2) * Introduce new interface `IServiceListener` to represent each listener in StatefulService. This allows us to develop each listener separately. Migrate current codebase to consume the same.
shankarsama
requested review from
Chris Gillum (cgillum) and
Simon Porter (simonporter)
July 16, 2019 22:58
shankarsama
requested review from
Pradeep Kadubandi (PradeepKadubandi) and
Affan Dar (affandar)
July 16, 2019 23:00
Contributor
There was a problem hiding this comment.
CleanupOldDictionaries [](start = 13, length = 22)
Async
Contributor
There was a problem hiding this comment.
Exceptions [](start = 29, length = 10)
Here and a few other places, use singular in classnames not plural. Also SessionMessagesProvider, SessionsProvider.
Contributor
There was a problem hiding this comment.
Task [](start = 15, length = 4)
Interested why a hashing func would return a task. If this should be like this naming should have async suffix
Update version. Address comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will introduce new provider based on Azure Service Fabric.
For more detailed notes refer to src\DurableTask.AzureServiceFabric\ReadMe.md