Skip to content

Fix for the issue with multiple Terminate events in a single batch #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simon Porter (simonporter) merged 1 commit into from
Aug 30, 2017
Merged

Fix for the issue with multiple Terminate events in a single batch #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/DurableTask.Core/TaskOrchestrationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ internal class TaskOrchestrationContext : OrchestrationContext
readonly IDictionary<int, OrchestratorAction> orchestratorActionsMap;
readonly TaskScheduler taskScheduler;
OrchestrationCompleteOrchestratorAction continueAsNew;
bool executionTerminated;
int idCounter;

public TaskOrchestrationContext(OrchestrationInstance orchestrationInstance, TaskScheduler taskScheduler)
Expand Down Expand Up @@ -376,7 +377,11 @@ private void LogDuplicateEvent(string source, HistoryEvent historyEvent, int tas

public void HandleExecutionTerminatedEvent(ExecutionTerminatedEvent terminatedEvent)
{
CompleteOrchestration(terminatedEvent.Input, null, OrchestrationStatus.Terminated);
if (!executionTerminated)
{
executionTerminated = true;
CompleteOrchestration(terminatedEvent.Input, null, OrchestrationStatus.Terminated);
}
}

public void CompleteOrchestration(string result)
Expand Down