Repository navigation
fix: ignore nonliteral backend IDs - #332
Danny Ward (dannyward630) wants to merge 1 commit into
Conversation
|
Danny Ward (@dannyward630) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
|
Danny Ward (@dannyward630) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves literal backend handling and includes targeted regression coverage, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Fixes #331 by excluding named-value placeholders and APIM expressions from literal backend discovery, preventing false backend requests during extraction.
Changes:
- Filters nonliteral backend IDs while preserving literal backend handling.
- Keeps named-value references available for discovery.
- Adds resolver and extractor regression tests for the reported failure.
| File | Description |
|---|---|
tests/unit/services/transitive-resolver.test.ts |
Tests exclusion of placeholders and expressions from backend references. |
tests/unit/services/transitive-extractor.test.ts |
Tests named-value extraction without requesting the placeholder as a backend. |
src/services/transitive-resolver.ts |
Adds a literal-backend-ID check before registering backend dependencies. |
Review effort: Balanced
Summary
{{named-value}}references available to named-value discovery without requesting them as literal backends.@(...)and@{...}) during transitive backend discovery.Validation
npm run lint— passednpm run build— passednpm test— passed (1,650 passed, 2 skipped)Related Issue(s)
Closes #331
Assisted by Codex (GPT-6).