Skip to content

Enable to run on ROS Melodic - #38

Merged
jacobperron merged 3 commits into
AutonomyLab:masterfrom
youtalk:melodic-devel
Aug 19, 2019
Merged

jacobperron merged 3 commits into
AutonomyLab:masterfrom
youtalk:melodic-devel

Conversation

@youtalk

@youtalk youtalk commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

Solved AutonomyLab/create_robot#54

When I used this package on Ubuntu 18.04 and ROS Melodic, I had the same problem above.

roslaunch ca_driver create_2.launch
...
[ INFO] [1549365785.956563724]: [CREATE] "CREATE_2" selected
[create::Serial] failed to receive data from Create. Check if robot is powered!
[create::Create] retrying to establish serial connection...
[create::Serial] serial error - Operation canceled
[create::Serial] failed to receive data from Create. Check if robot is powered!
[create::Create] retrying to establish serial connection...
[create::Serial] serial error - Operation canceled
...

This PR solves it based on AutonomyLab/create_robot#54 (comment)

@lopsided98 lopsided98 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does d2cc4b9 fix? I would recommend adding more explanation to the commit message. In particular, why was 0.1 chosen?

@lopsided98

Copy link
Copy Markdown
Contributor

I don't currently have ROS setup on my Create, so I can't test this. I might get it running again in the next few weeks, but I'm not sure I'll have time.

This reverts commit d2cc4b9.
@youtalk

youtalk commented Mar 9, 2019

Copy link
Copy Markdown
Contributor Author

@lopsided98 I'm sorry but d2cc4b9 was my mistake to push. I reverted the commit.

@jacobperron

Copy link
Copy Markdown
Member

@youtalk Thanks for the patch. I'll try to set aside some time to test it this week and I can work on a release for Melodic.

@komeihasegawa

Copy link
Copy Markdown

This worked fine with my Ubuntu18.04, ROS Melodic, and Create1.

@jacobperron
jacobperron merged commit 2442ba2 into AutonomyLab:master Aug 19, 2019
@youtalk
youtalk deleted the melodic-devel branch August 19, 2019 22:34
@youtalk
youtalk restored the melodic-devel branch August 19, 2019 22:58
@youtalk
youtalk deleted the melodic-devel branch August 19, 2019 23:24
eborghi10 pushed a commit to RoboticaUtnFrba/libcreate that referenced this pull request Dec 5, 2019
eborghi10 pushed a commit to RoboticaUtnFrba/libcreate that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants