Repository navigation
Enable to run on ROS Melodic - #38
Merged
Merged
Conversation
This was referenced Mar 2, 2019
lopsided98
reviewed
Mar 7, 2019
Contributor
There was a problem hiding this comment.
What does d2cc4b9 fix? I would recommend adding more explanation to the commit message. In particular, why was 0.1 chosen?
Contributor
|
I don't currently have ROS setup on my Create, so I can't test this. I might get it running again in the next few weeks, but I'm not sure I'll have time. |
This reverts commit d2cc4b9.
Contributor
Author
|
@lopsided98 I'm sorry but d2cc4b9 was my mistake to push. I reverted the commit. |
Member
|
@youtalk Thanks for the patch. I'll try to set aside some time to test it this week and I can work on a release for Melodic. |
2 tasks done
|
This worked fine with my Ubuntu18.04, ROS Melodic, and Create1. |
eborghi10
pushed a commit
to RoboticaUtnFrba/libcreate
that referenced
this pull request
Dec 5, 2019
eborghi10
pushed a commit
to RoboticaUtnFrba/libcreate
that referenced
this pull request
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved AutonomyLab/create_robot#54
When I used this package on Ubuntu 18.04 and ROS Melodic, I had the same problem above.
This PR solves it based on AutonomyLab/create_robot#54 (comment)