Skip to content

Add a connect timeout explicitly to hyperdb. - #129

Open
dd32 wants to merge 1 commit into
trunkfrom
merge/opt-connect-timeout
Open

dd32 wants to merge 1 commit into
trunkfrom
merge/opt-connect-timeout

Conversation

@dd32

@dd32 dd32 commented Feb 28, 2023

Copy link
Copy Markdown
Member

Add a connect timeout explicitly to wpdb. While this generally has the same effect as the default_socket_timeout ini setting, but hopefully in future PHPs it would apply to the whole handshake.


While upgrading HyperDB on WordPress.org, I spotted that we have a customization on WordPress.org & WordPress.com that hasn't been added to HyperDB on GitHub.

It initially appears that this might be a bugfix that doesn't apply to HyperDB directly with currently released versions of PHP, but as I can't see any harm in upstreaming this, and can't find any open PHP Bugs seemingly related to it, I'm PR'ing it here for reference and determinations.

@vnsavage I've requested review from you as you're the original author. Is this something that is safe to merge to HyperDB? Or should it be kept as a customization on the platforms?

…e same effect as the default_socket_timeout ini setting, but hopefully in future PHPs it would apply to the whole handshake.
@dd32
dd32 requested a review from vnsavage February 28, 2023 02:13
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vnsavage

Copy link
Copy Markdown
Contributor

You are correct - that change doesn't do anything without a bug fix on the PHP side which we have on WP.com/WP.org. There is a pull requests pending here: php/php-src#9532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants