You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add asbuild utility, update asinit to use it - #1134
At a high level, this separates out invocation of asc from npm (and several quirks related to targets passing arguments) by creating a new command: asbuild.
It supports explicitly passing flags to asc, but mainly focuses on build profiles, each of which corresponds to a certain set of flags. These profiles can easily be added or updated by updating a JSON file.
Usage examples:
asbuild # runs a debug build
asbuild --release # runs a build with maximum optimization
asbuild --relmin # runs a build that is optimized for size
asbuild --debug --release # runs both a debug and a release build
This new tool uses existing command-line parsing, does not add any dependencies, and allows explicitly specifying output file names the same way that asc does.
This completes the work started in #975, and incorporates all feedback from that discussion.
Has taken me a while to get back to this issue, sorry. While I believe we need something better here, and this is going into the right direction, I am uncertain whether we have pinpointed the optimal solution yet. The new asconfig efforts highlight some of the potential conflicts in that their extends mechanism would cover AS-provided presets, and their targets mechanism would allow multiple targets with slightly varying config options. Like, in a world with asconfig, I'd imagine asbuild to become a more convenient shorthand for asc --config asbuild.json --target something, i.e. asbuild something, so I have been wondering if both efforts can be combined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a high level, this separates out invocation of
ascfromnpm(and several quirks related to targets passing arguments) by creating a new command:asbuild.It supports explicitly passing flags to
asc, but mainly focuses on build profiles, each of which corresponds to a certain set of flags. These profiles can easily be added or updated by updating a JSON file.Usage examples:
This new tool uses existing command-line parsing, does not add any dependencies, and allows explicitly specifying output file names the same way that
ascdoes.This completes the work started in #975, and incorporates all feedback from that discussion.