Repository navigation
build.sh: follow a symlinked JAR_LIB_DIR - #35
Merged
Merged
Conversation
The jar check used `find "$JAR_LIB_DIR"`, which does not follow a symlinked starting point, so a build with a symlinked lib directory failed with "No JAR files found". The check now uses `find -H`, and the staging copy uses `cp -aL` so a jar that is itself a symlink is staged as a real file (a copied link would dangle in the Docker build context and be skipped by the `find -type f` hash). One line added to CLAUDE.md. Port of humemai/arcadedb-embedded-python#463. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
8 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of humemai/arcadedb-embedded-python#463 (merged there). Based on
main.The jar check in
scripts/build.shusedfind "$JAR_LIB_DIR", which does not follow a symlinked starting point, so a build with a symlinked lib directory failed with "No JAR files found". The check now usesfind -H, and the staging copy usescp -aLso a jar that is itself a symlink is staged as a real file (a copied link would dangle in the Docker build context and be skipped by thefind -type fhash). One line added to the Build section ofCLAUDE.md. Thedocs/development/build-architecture.mdhunk of the original does not apply: that page does not exist in this repo.Checked by running
build.sh linux/amd64 3.12 <symlinked dir>with a fakedockeron PATH (it fails atdocker build, after the staging step) against a symlinked directory holding one real jar and one symlinked jar. Onmain: "No JAR files found". With this change: the directory is accepted and both jars land inlocal-jars/libas regular files.pre-commit(shfmt) passes. No test coversbuild.sh, so none was added, and no full build was run since the change does not touch anything after the staging step; CI builds the wheels.Possible conflict: #20 also edits
scripts/build.sh, but at a different place (around line 506, the studio jar exclusion), so I expect a clean merge. #28 and #29 do not touch these lines.🤖 Generated with Claude Code