You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build.sh: extract_version failure at line 405 is swallowed, fails later with a misleading message #4
At scripts/build.sh:405, ARCADEDB_VERSION="$(python3 "$SCRIPT_DIR/extract_version.py" ...)" runs as an environment assignment in front of a command. Because of that, set -e doesn't stop the build when extract_version.py fails, for example when there is no engine jar or there are two engine versions. The script carries on with an empty ARCADEDB_VERSION.
The build still fails later, but with a message that doesn't point at the real cause. Proposed fix: compute the value on its own line and exit with the extractor's error.
Found in the final review of the move from ArcadeData/arcadedb (#1).
Activity
Merge pull request #11 from ArcadeData/fix/4-build-sh-extract-version…