Repository navigation
Fix shapeshifer - #161
Fix shapeshifer#161Kamelitoloveless wants to merge 5 commits into
Conversation
…ooks Programs that SetFunction() ExitIntr() and Schedule(), or replace ex_LaunchPoint, were never called on m68k (issue #1460). - SFF_SoftInt, SFF_QuantumOver and the pending-switch flag (now SFF_AttnSwitch, replacing ARF_AttnSwitch in AttnResched) are SysFlags bits 13, 14 and 15 on every target, as on Kickstart. Cause() updates SysFlags atomically unless AROS_NO_ATOMIC_OPERATIONS is set. - m68k interrupt handlers leave through the ExitIntr() vector with SysBase pushed, as Kickstart's level handlers do, and ExitIntr() pops it. - m68k Schedule() decides with interrupts masked, as on Kickstart, so the scheduler's non-atomic flag updates cannot lose a bit. - m68k Dispatch() enters the task through ex_LaunchPoint, publishing its own launch code there on first use.
|
Thanks for the work on this! However, my take is that we shouldn't merge this PR. The original ShapeShifter relied on undocumented Kickstart 3.x internals (private ExitIntr/Schedule stack layouts, ex_LaunchPoint, and scratch registers surviving OS calls). Reworking ApolloOS's exec.library task switching and interrupt handling to mimic those undocumented Kickstart quirks carries too much risk of breaking task switching, SuperState() tasks, and 68080/AMMX context handling for the rest of the OS. Instead, we have updated ShapeShifter itself to handle interrupts, task switching, and OS calls cleanly, and it now runs natively on ApolloOS without needing any changes to exec.library. |
|
This fix was also merged into Aros repo. I have not seen so far any regression, I found ApolloOS quite solid with this code. |
ShapeShifter patch using two undocumted Exec functions.
One is not implemented in Aros / ApolloOS which is :
ExitIntr found in rom/exec/exitintr.c
This PR has been created to include the changes done by Aros dev Kalamatee which I reported in the issue below.
aros-development-team/AROS#1460