Repository navigation
Sort subfolders in content_files for a stable order - #6
Merged
Merged
Conversation
os.walk returns subfolders in file system order, which differs between macOS and Linux, so CODEOWNERS was generated in a different order locally and in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
content_files()only sorted top-level folders.os.walkreturns deeper subfolders in file system order, which isn't alphabetical and differs between macOS and Linux. Sogenerate_codeowners.pygave a different CODEOWNERS order on a Mac than in CI. That's why the Regenerate CODEOWNERS workflow pushedb33e1b5after #5, which only swapped two lines.The fix sorts subfolders at every level. CODEOWNERS is regenerated in the now-stable alphabetical order.
The
b33e1b5push also confirms that the CODEOWNERS workflow can push tomainthrough the ruleset with its deploy key.🤖 Generated with Claude Code