Skip to content

Sort subfolders in content_files for a stable order - #6

Merged
WDrijver merged 1 commit into
mainfrom
fix-codeowners-order
Nov 3, 2026
Merged

WDrijver merged 1 commit into
mainfrom
fix-codeowners-order

Conversation

@WDrijver

@WDrijver WDrijver commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

content_files() only sorted top-level folders. os.walk returns deeper subfolders in file system order, which isn't alphabetical and differs between macOS and Linux. So generate_codeowners.py gave a different CODEOWNERS order on a Mac than in CI. That's why the Regenerate CODEOWNERS workflow pushed b33e1b5 after #5, which only swapped two lines.

The fix sorts subfolders at every level. CODEOWNERS is regenerated in the now-stable alphabetical order.

The b33e1b5 push also confirms that the CODEOWNERS workflow can push to main through the ruleset with its deploy key.

🤖 Generated with Claude Code

os.walk returns subfolders in file system order, which differs between
macOS and Linux, so CODEOWNERS was generated in a different order locally
and in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@WDrijver
WDrijver requested a review from TuKo1982 as a code owner November 2, 2026 13:20
@WDrijver
WDrijver merged commit 87d9d40 into main Nov 3, 2026
2 checks passed
@WDrijver
WDrijver deleted the fix-codeowners-order branch November 3, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant