Skip to content

feat(simulation): replace policy host with generic pipe feedback - #12

Merged
ZGZ713912 merged 2 commits into
mainfrom
dev/wheel-leg-refactor
Nov 15, 2026
Merged

ZGZ713912 merged 2 commits into
mainfrom
dev/wheel-leg-refactor

Conversation

@ZGZ713912

Copy link
Copy Markdown
Member

Replace the bespoke wheel-leg simulation host with the generic rmcs_rl::PipeFeedback plugin loaded by the normal executor. YAML declares typed feedback outputs and result inputs; a command partner emits one response per batch. The new five-component simulation configuration uses stepped time, and policy submission/expiry now use the executor timestamp so a slow simulation does not expire actions against wall time.

The obsolete export/prepare tools are removed in a separate prerequisite commit after the checker landed in rmcs_rl main (PR #11) and the exporter/header generator landed in V10 (training PR #2). Keep the latency benchmark, dependency installer, mirror and 16001 fallback model.

Validation: container build; all eight generic pipe types, default/batched ticks, retained values, EOF and six malformed input cases; 1000 stepped ticks in 2.89 ms with no skipped tick and exact 1 ms virtual increments; realtime 1000 ticks in 1001.83 ms; normal-executor/client handshake and a 150 ms wall pause without spurious action expiry; 602 recorded synthetic pilot frames compared to the preserved old host, 150 action sequences aligned and 600 same-batch comparisons, with zero torque error. The old host is removed after this comparison. No real hardware or native PhysX behavior acceptance was run.

RMCS must include the clock/startup-order correction on feat/executor-stepped-clock. The wheel-leg branch has been rebased onto it; the deformable integration branch includes the same prerequisite. Per the user's updated instruction RMCS PR #105 is closed and the correction stays on that feature branch, rather than being merged into RMCS main.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ZGZ713912
ZGZ713912 merged commit 5bd7edf into main Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant