Repository navigation
feat(simulation): replace policy host with generic pipe feedback - #12
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ZGZ713912
added a commit
that referenced
this pull request
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the bespoke wheel-leg simulation host with the generic rmcs_rl::PipeFeedback plugin loaded by the normal executor. YAML declares typed feedback outputs and result inputs; a command partner emits one response per batch. The new five-component simulation configuration uses stepped time, and policy submission/expiry now use the executor timestamp so a slow simulation does not expire actions against wall time.
The obsolete export/prepare tools are removed in a separate prerequisite commit after the checker landed in rmcs_rl main (PR #11) and the exporter/header generator landed in V10 (training PR #2). Keep the latency benchmark, dependency installer, mirror and 16001 fallback model.
Validation: container build; all eight generic pipe types, default/batched ticks, retained values, EOF and six malformed input cases; 1000 stepped ticks in 2.89 ms with no skipped tick and exact 1 ms virtual increments; realtime 1000 ticks in 1001.83 ms; normal-executor/client handshake and a 150 ms wall pause without spurious action expiry; 602 recorded synthetic pilot frames compared to the preserved old host, 150 action sequences aligned and 600 same-batch comparisons, with zero torque error. The old host is removed after this comparison. No real hardware or native PhysX behavior acceptance was run.
RMCS must include the clock/startup-order correction on feat/executor-stepped-clock. The wheel-leg branch has been rebased onto it; the deformable integration branch includes the same prerequisite. Per the user's updated instruction RMCS PR #105 is closed and the correction stays on that feature branch, rather than being merged into RMCS main.