Repository navigation
Conversation
- hardware: WheelLegInfantry component (rmcs_board_lite + 4x DM-J8009-2EC hip via new dm_motor.hpp MIT driver + 2x M3508 wheels, BMI088 IMU, DR16) - bringup: wheel-leg-infantry.yaml (hardware + rmcs::rl::RlController wiring) - submodule: rmcs_rl (generic RL policy deployment, see rmcs_ws/src/rmcs_rl) NOTE: .gitmodules URL is a placeholder; replace before pushing Co-authored-by: ZGZ713912 <zgz713912@gmail.com>
Organize wheel-leg hardware, chassis commands, PD identification and RL recovery around RMCS components, explicit phase types and fixed-size data. Keep the final 50 Hz target / 1 kHz PD identification path, archive legacy experiments and remove the unused RL consumer. Fix DOWN reset after clock faults, nonfinite recovery settings, PLANT pitch bias, recovery cadence and elapsed-time accounting. Preserve CAN ordering, actuation deadline checks and the packaged V5 policy contract. Include the existing wheel-leg implementation, profiles, recording tools and supporting documentation required by the refactor. Raw NPZ recordings and unrelated local development changes remain outside this commit. Validation: rmcs_core and rmcs_rl build successfully; 128 gtests pass. Python identification tests: 83 passed / 6 skipped on the host; ROS-enabled configuration and recording subset: 83 passed / 5 skipped. Hardware and V6 closed-loop migration are not validated by these offline checks.
Implement paired-leg recording protocols, frozen calibration profiles, offline previews and qualified bag export. Publish atomic motor/IMU samples with monotonic sequences and host timestamps for downstream control guards.
Use right-stick/WASD translation, left-stick yaw and the DR16 rotary height request. Toggle pure spin on the left-middle/right-down rising edge or C. Preserve double-down disarm and require an armed session plus explicit controller request before the spin switch can keep hardware enabled.
Bind model SHA, nominal angles, motor mapping and native 50Hz/200Hz control parameters as one profile. Compare the production ONNX and Component path against the sealed native fixtures. Require fresh synchronized sensors in ordinary V6 control and reject legacy recovery under the new flat candidate; retain V5 self-righting evidence and regression in its own explicit profile.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind wheel-leg control to the simplified rmcs_rl bridge and a version-neutral jump policy header. The bridge now exposes bool validity and loaded metadata, while the controller validates its compiled deployment contract. Retain the generic StateMirror in both full and gimbal profiles and use fresh six-motor/IMU feedback to gate control. DM faults remain latched until the explicit arming/reset flow.
The branch has been rebased onto feat/executor-stepped-clock, retaining merge history, and pins rmcs_rl main 5bd7edf. The header names its committed generator in the training V10 branch. The shared gravity feedforward component now requires its two configured parameters. Concurrent IMU/CSV diagnostics remain uncommitted in the workspace and are excluded from this PR.
Validation: container build; 87,848 observation frames with zero feature error; hardware-message regressions; full/gimbal graph loading; exact contract and mirror-type rejection; history/flat-hold comparison against ccdeb79; generic mirror and replay tests; 602 synthetic pipe frames compared to the preserved legacy host with zero aligned torque error; 1000 stepped ticks without skipped periods. See rmcs_rl PRs #11/#12 and training PRs ZGZ713912/isaac_sim-tasks#2/#3 for the library/exporter/pipe changes.
Draft: no accepted jump ONNX exists yet. Production YAML retains a missing-model/sentinel contract and rejects pilot exports. The current V10 checkpoint uses a five-frame newest-first history, which must be reconciled with the chosen deployment contract before an accepted export is installed. Bench and real-vehicle behavior are unverified.
The 16001 fallback remains at wheel-leg-16001-stable (ac6bfa7, rmcs_rl 26d29ce); its branch and the old PR #104 are retained. This PR represents the current refactor branch.