Repository navigation
Scan both readings of a body that is a form and JSON - #789
Open
iacobdaniel wants to merge 2 commits into
Open
iacobdaniel wants to merge 2 commits into
iacobdaniel wants to merge 2 commits into
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A body can be valid JSON and also parse as a form, and the app may read it either way. Zen kept only one reading: Django and Quart scanned only the form when JSON was sent with a form content type, and Starlette/FastAPI scanned only the JSON, missing form fields inside it. Both readings are now scanned, including JSON with a BOM or in UTF-16/32. Normal requests are unchanged.