Repository navigation
fix(mcpb): keep vendor/ paths in the bundle - the release workflow's first 0.4.1 run caught it - #16
Merged
Merged
Conversation
…undle The release workflow's first run on 0.4.1 (dispatch 43636302168, measured 2026-11-14) failed its own proof step: `test/mcpb-start.mjs` reported "hjaelperen er med i pakken" as DUMP. Cause: since 5a1b835 (6 Nov) `mcp-server/package.json` lists the two proven artifacts as `vendor/cmcp-helper` and `vendor/ComputerMCPStatus.app`, but `scripts/build-mcpb.sh` copied every entry with `cp -R "$f" "$SRV/"`, which drops the directory part. The helper landed in `server/cmcp-helper`, while the server looks for it under `server/vendor/`. Measured both ways in a scratch tree: the old loop flattens, the new one keeps the path - the same layout npm itself ships. The status app had the same fault and no guard, so the proof step now checks it too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The release workflow had never run in its current form. The only run before tonight was v0.2.0 on 20 Sep, before the MCPB steps were added. Before tagging 0.4.1 we started it once by hand with an empty tag input, which builds main without uploading anything. Run 43636302168 failed in its own proof step:
Since 5a1b835 (6 Nov),
mcp-server/package.jsonlists the two proven artifacts asvendor/cmcp-helperandvendor/ComputerMCPStatus.app.scripts/build-mcpb.shcopied each entry withcp -R "$f" "$SRV/", which drops the directory part. The helper and the status app therefore ended up next toindex.js, while the server looks for them undervendor/.The 0.4.1 notes (
CHANGELOG.md, 0.4.1 section) say the GitHub release carries the binary and the .mcpb bundle built by CI from the tag. Without this fix, the tag run would have failed before uploading either of them.The fix
scripts/build-mcpb.shkeeps each entry's path (mkdir -p+cp -Rto the same relative path). This is the layout npm itself ships.test/mcpb-start.mjsalso checks the status app, which had the same fault and no check.Measured
successon 4d95c52, including "Byg og bevis MCPB-pakken". Upload is skipped, because this was a manual run../cmcp-helperand./ComputerMCPStatus.app/…, the new one./vendor/cmcp-helperand./vendor/ComputerMCPStatus.app/….scripts/andtest/change, and npm packsmcp-server/. The integrity was computed with the release script's own procedure (git archive, the attested binaries,PUBLICERET=0.4.1,sync-tal.py,npm pack). Both on 8784542 (control) and on 4d95c52 it is the reviewedsha512-5vnxkav…, 19 files.🤖 Generated with Claude Code