Repository navigation
deps(vscode): bump vitest to 5 with Node 22 and @types/node 22 - #184
Merged
Merged
Conversation
Supersedes dependabot PR #170, which bumped vitest 4 -> 5 alone and failed the vscode-extension CI job at npm ci: vitest 5 declares @types/node as an optional peer at ^22 || >=24, the extension pinned ^20, and npm rejected the tree with ERESOLVE. vitest 5 also needs Node 22 at runtime. Bump @types/node to ^22 and regenerate the lockfile, move the vscode-extension CI job to Node 22 (the other Node jobs stay on 20), and rename vitest.config.ts to .mts so Vite 8 loads it as ESM instead of warning about ESM syntax in a CommonJS file. The .vscodeignore entry follows the rename, since its **/*.ts glob does not match .mts. Verified under Node 22 from a clean npm ci: build, tsc, eslint, vitest (53/53), and the vsce package dry-run all pass. Spec: specs/vscode-vitest-5.md Signed-off-by: Jose Alekhinne <jose@ctx.ist>
bilersan
added a commit
to bilersan/ctx
that referenced
this pull request
Oct 8, 2026
Brings in ActiveMemory#184 (vitest 5, Node 22, vitest.config.ts -> .mts), ActiveMemory#185-ActiveMemory#189 and PR ActiveMemory#177. Git applied the branch's md-as-text plugin to the renamed vitest.config.mts; no conflicts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Ersan Bilik <ersanbilik@gmail.com>
bilersan
added a commit
to bilersan/ctx
that referenced
this pull request
Oct 8, 2026
Upstream ActiveMemory#184 moved the vitest config to .mts; the README still pointed at the .ts name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Spec: specs/vscode-skill-backed-participant.md Signed-off-by: Ersan Bilik <ersanbilik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes dependabot PR #170, which bumped vitest 4 -> 5 alone and
failed the vscode-extension CI job at npm ci: vitest 5 declares
@types/node as an optional peer at ^22 || >=24, the extension pinned
^20, and npm rejected the tree with ERESOLVE. vitest 5 also needs
Node 22 at runtime.
Bump @types/node to ^22 and regenerate the lockfile, move the
vscode-extension CI job to Node 22 (the other Node jobs stay on 20),
and rename vitest.config.ts to .mts so Vite 8 loads it as ESM
instead of warning about ESM syntax in a CommonJS file. The
.vscodeignore entry follows the rename, since its **/*.ts glob does
not match .mts.
Verified under Node 22 from a clean npm ci: build, tsc, eslint,
vitest (53/53), and the vsce package dry-run all pass.
Spec: specs/vscode-vitest-5.md
🤖 Generated with Claude Code