Repository navigation
Use timeframes and cooldowns instead of gmcp.IRE.Display.ButtonActions - #63
Conversation
…ies on using timeframes and cooldowns for rageAvailable-ity!
|
Err.. |
keneanung
left a comment
There was a problem hiding this comment.
I can't remember exactly, but wasn't there a shoet period where all battlerage attacks went on cooldown as well?
| keneanung.bashing.targetList = {} | ||
| keneanung.bashing.systems = {} | ||
| keneanung.bashing.battlerage = {} | ||
| keneanung.bashing.battlerageSkillsCD = {} -- I couldn't get it to work as a local in a tempTimer D: |
There was a problem hiding this comment.
You should be able to use locals if you handed tables with {time, changeFunction} to timeframe IIRC.
There was a problem hiding this comment.
Ohh, this was an old comment when I was still hammering on it with tempTimer and didn't know about timeframe. I'll remove it.
There was a problem hiding this comment.
I'd actually prefer to use locals nowadays. Could you change to that? Maybe you can even give the function a setter function as first argument instead of a variable name? I can't look it up right now.
|
Oh, hmm. There -is- a mention of a global cooldown on it in HELP BATTLERAGE. Lemme read up on it and see if we need to change anything |
|
I found it! It was in https://www.achaea.com/news/?game=Achaea§ion=announce&number=4349:
|
|
But we already have code to take care of that here: |
|
That was meant as a failsafe to avoid spamming rage attacks during the command roundtrip. But if it catches that, good enough. The button usage was implemented because I didn't want to write a full rage tracking system (cooldown, did they go through, etc...) |
|
Umm.. how do I make a release if I wanted to get people on board to test it? 😮 |
|
Whoo! I found out how. Although it's not automated like yours: |
Hi! This pull request proposes using timeframes to manage battlerage cooldowns and removes the dependency on
gmcp.IRE.Display.ButtonActionsfor us. Please let me know what you think!