Skip to content

Use timeframes and cooldowns instead of gmcp.IRE.Display.ButtonActions - #63

Merged
keneanung merged 4 commits into
AchaeaBashingScript:moveBattlerageToAttainmentfrom
adayoung:cooldown2rageAvailable
Oct 17, 2018
Merged

keneanung merged 4 commits into
AchaeaBashingScript:moveBattlerageToAttainmentfrom
adayoung:cooldown2rageAvailable

Conversation

@adayoung

Copy link
Copy Markdown
Member

Hi! This pull request proposes using timeframes to manage battlerage cooldowns and removes the dependency on gmcp.IRE.Display.ButtonActions for us. Please let me know what you think!

…ies on using timeframes and cooldowns for rageAvailable-ity!
@adayoung

Copy link
Copy Markdown
Member Author

@adayoung

Copy link
Copy Markdown
Member Author

Err.. keneanung.bashing.battlerage.setCooldown or what it does should probably be moved to sendRageAttack() ..?

@keneanung keneanung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember exactly, but wasn't there a shoet period where all battlerage attacks went on cooldown as well?

Comment thread script.lua Outdated
keneanung.bashing.targetList = {}
keneanung.bashing.systems = {}
keneanung.bashing.battlerage = {}
keneanung.bashing.battlerageSkillsCD = {} -- I couldn't get it to work as a local in a tempTimer D:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use locals if you handed tables with {time, changeFunction} to timeframe IIRC.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, this was an old comment when I was still hammering on it with tempTimer and didn't know about timeframe. I'll remove it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer to use locals nowadays. Could you change to that? Maybe you can even give the function a setter function as first argument instead of a variable name? I can't look it up right now.

Comment thread script.lua Resolved
@adayoung

Copy link
Copy Markdown
Member Author

Oh, hmm. There -is- a mention of a global cooldown on it in HELP BATTLERAGE. Lemme read up on it and see if we need to change anything

@adayoung

Copy link
Copy Markdown
Member Author

I found it! It was in https://www.achaea.com/news/?game=Achaea&section=announce&number=4349:

  • All Battlerage abilities now have a shared cooldown of 1 second during which you cannot execute any other Battlerage abilities.

@adayoung

adayoung commented Oct 17, 2018 •

Copy link
Copy Markdown
Member Author

@keneanung

Copy link
Copy Markdown
Member

That was meant as a failsafe to avoid spamming rage attacks during the command roundtrip. But if it catches that, good enough.

The button usage was implemented because I didn't want to write a full rage tracking system (cooldown, did they go through, etc...)

@adayoung

Copy link
Copy Markdown
Member Author

Umm.. how do I make a release if I wanted to get people on board to test it? 😮

@adayoung

Copy link
Copy Markdown
Member Author

Whoo! I found out how. Although it's not automated like yours:
https://github.com/adayoung/Bashing/releases/tag/1.9-pre-2594940-cooldown2rageAvailable

@keneanung
keneanung merged commit e5678ed into AchaeaBashingScript:moveBattlerageToAttainment Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants