Repository navigation
Uds 2265 - #1817
Uds 2265#1817spaceperson wants to merge 2 commits into
Conversation
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1817/index.html |
|
|
||
| [role="doc-subtitle"] { | ||
| margin-top: auto; | ||
| margin-left: 0.37rem; |
There was a problem hiding this comment.
Quick question, where does 0.37rem come from? If it's meant to line up the h3 highlight padding with the h1 highlight, please add a short comment, or use a $uds-size-spacing-* token if one fits.
Also, this offset applies even when the subtitle has no highlight (highlightColor: "none"). Can we confirm that case still aligns with the title?
| div.uds-hero-sm { | ||
| grid-template-rows: 0px 1fr auto auto; | ||
|
|
||
| [role="doc-subtitle"] { |
There was a problem hiding this comment.
Everywhere else in this file, [role="doc-subtitle"] is paired with .hero-subtitle, since the role selector is deprecated. With only the role selector here, markup using .hero-subtitle (HTML/Twig consumers) still has the spacing bug. Suggest (please double check in any case)
[role="doc-subtitle"],
.hero-subtitle {
margin-top: auto;
margin-left: 0.37rem;
}
|
Hi @spaceperson |
Description
Checklist
Important Reminders
Links