This repository was archived by the owner on Jan 15, 2026. It is now read-only.
Repository navigation
Fix android bg - #587
Closed
douglas-raillard-arm wants to merge 2 commits into
Closed
Fix android bg#587douglas-raillard-arm wants to merge 2 commits into
douglas-raillard-arm wants to merge 2 commits into
Conversation
douglas-raillard-arm
force-pushed
the
fix_android_bg
branch
2 times, most recently
from
June 26, 2023 12:19
4d8fbe2 to
c2b1b1d
Compare
douglas-raillard-arm
force-pushed
the
fix_android_bg
branch
from
July 5, 2023 10:17
1bf4f9a to
3ff5481
Compare
Merged
Close the race between the background command and the detection of its PID by freezing it while we detect the PID, then resuming it.
PID detection can sometimes fail for unknown reason. Maybe there is a latency between the process being started and "ps" being able to see it that can sometimes be high enough that we look for the process before it's exposed. In order to remedy that, add a retry logic to avoid plain failures.
douglas-raillard-arm
force-pushed
the
fix_android_bg
branch
from
September 11, 2023 15:14
3ff5481 to
e4622ef
Compare
Collaborator
Author
|
@marcbonnici it looks like the branch was merged in |
Collaborator
|
Ah it looks like these changes was accidentally merged as part of #639 so it looks like we can close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting this change from the async PR as the async PR no longer relies on background():
#569