Repository navigation
test: trim the gallery tests to the gallery - #36
Merged
Merged
Conversation
The Pump and Outlet scene tests checked what PumpTests and OutletTests already check more closely, so a Gallery test now checks only the Gallery: the build, the key blocks, and a sign rebuilding its scene. Closes #29 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamico
enabled auto-merge (squash)
October 17, 2026 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Gallery test now checks only the Gallery itself. Scene behaviour is left to the mechanics' own game tests, which already check it more closely.
a_pump_beside_water_fills_its_pipe_and_leaves_the_water,a_pump_beside_lava_takes_the_source_block_into_a_tank(exact amounts)an_outlet_sets_a_bucket_of_water_down_as_a_source_block(500 mB left too)The Pump → pipe → Outlet chain in the Outlet scene is no longer tested end to end. That was accepted in triage, and the scene is checked by eye in the dev client.
Closes #29
Evidence
runGameTestServerran 4 Gallery tests.After:
sh ./gradlew build runGameTestServer→All 129 required tests passed. The Gallery tests that ran weregallery_builds_a_scene_of_each_featureandgallery_scenes_sign_clicked_builds_the_scene_again, and the three covering Pump and Outlet tests ran and passed.Merge Danger
Door: two-way
Only game-test code changes; it never ships. Reverting the commit brings the tests back.
Blast Radius: none
There are no Consumer-facing or shipped changes, so there's no CHANGELOG line.
🤖 Generated with Claude Code