Skip to content

test: trim the gallery tests to the gallery - #36

Merged
adamico merged 1 commit into
mainfrom
claude/triage-29-b4a3d1
Oct 17, 2026
Merged

adamico merged 1 commit into
mainfrom
claude/triage-29-b4a3d1

Conversation

@adamico

@adamico adamico commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Summary

A Gallery test now checks only the Gallery itself. Scene behaviour is left to the mechanics' own game tests, which already check it more closely.

 GalleryTests.register
   gallery_builds_a_scene_of_each_feature
-  gallery_pump_scene_leaves_its_water_and_takes_its_lava   # covered by PumpTests
-  gallery_outlet_scene_sets_its_water_down                 # covered by OutletTests
   gallery_scenes_sign_clicked_builds_the_scene_again
Cut Already covered by
Pump scene: water kept, lava taken a_pump_beside_water_fills_its_pipe_and_leaves_the_water, a_pump_beside_lava_takes_the_source_block_into_a_tank (exact amounts)
Outlet scene: water set down an_outlet_sets_a_bucket_of_water_down_as_a_source_block (500 mB left too)

The Pump → pipe → Outlet chain in the Outlet scene is no longer tested end to end. That was accepted in triage, and the scene is checked by eye in the dev client.

Closes #29

Evidence

  • Before: runGameTestServer ran 4 Gallery tests.
    After: sh ./gradlew build runGameTestServer → All 129 required tests passed. The Gallery tests that ran were gallery_builds_a_scene_of_each_feature and gallery_scenes_sign_clicked_builds_the_scene_again, and the three covering Pump and Outlet tests ran and passed.

Merge Danger

Door: two-way

Only game-test code changes; it never ships. Reverting the commit brings the tests back.

Blast Radius: none

There are no Consumer-facing or shipped changes, so there's no CHANGELOG line.

🤖 Generated with Claude Code

The Pump and Outlet scene tests checked what PumpTests and OutletTests
already check more closely, so a Gallery test now checks only the
Gallery: the build, the key blocks, and a sign rebuilding its scene.

Closes #29

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamico
adamico enabled auto-merge (squash) October 17, 2026 07:54
@adamico
adamico merged commit 47ace30 into main Oct 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check whether the gallery tests can be trimmed to the gallery

1 participant