Repository navigation
bug: a Vault update never overwrites secrets Vault already has - #777
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update on a Vault install generated values for keys its local env file lacked and patched them over the ones already in Vault, so running pods and new pods disagreed on the password.
migrate_secrets_to_vaultkeeps a key Vault already has (an empty one counts as missing) and still flips the local value toVAULT.backupfile instead of droppedK3S_TOKENandTAILSCALE_SECRET_IDcome from the server itself, so they still replace Vault'skv put -cas=0, so a failed read never empties or overwrites anything