Repository navigation
feature: a panel behind a reverse proxy can trust it to say who the visitor is - #775
Merged
Merged
Conversation
…isitor is TRUSTED_PROXIES in traefik-config.env lists the addresses whose X-Forwarded-* Traefik keeps. Without it every request behind a reverse proxy arrives as the proxy's address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behind an owner's own reverse proxy, Traefik replaces
X-Forwarded-Forwith the proxy's address, so the panel and anything behind it see every request as coming from the proxy.TRUSTED_PROXIESinoverlays/config/traefik-config.envlists the addresses (or ranges) whoseX-Forwarded-*Traefik keeps, on both ports. Empty by default, so nothing changes for existing installs. An entry that isn't an address or range, or is/0, stops the install.On 5stack.gg this is why the Internet exposure check reads "private address" for every install: the cloud sees the proxy, not the caller.
Tested:
tests/scripts/traefik_install_test.sh: values and validationtests/gateway/fresh_install_test.sh: an unlisted sender's header is dropped, a listed one's is kept, on a real cluster (CI)203.0.113.7, 172.70.1.1, <proxy>; unlisted →<sender>