Repository navigation
feat: publish the image for linux/arm64 as well as linux/amd64 - #19
Merged
Merged
Conversation
The image was amd64 only, so the action failed on arm64 runners with "no matching manifest for linux/arm64/v8". The release PR's image is now built natively on ubuntu-latest and ubuntu-24.04-arm, each pushed as release-pr-<arch>, then merged into one index whose digest action.yml pins. Before tagging a release, a verify matrix pulls the pinned index on each architecture, checks its revision label against the release commit and smoke tests it; publish checks the index holds both platforms and that the new tags resolve to the pinned digest. The commitlint workflow's source-build job also runs on arm64, with the npm cache keyed by architecture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image was amd64 only (as upstream's was), so the action failed on arm64 runners with
no matching manifest for linux/arm64/v8. This builds it for both architectures on native runners.release.yml:pin-imageis split into three jobs:main, decides whether to build (unchanged logic).ubuntu-latestandubuntu-24.04-arm; each builds with--provenance=falseand the revision label, and pushesrelease-pr-<arch>.docker buildx imagetools create, and commits the index digest toaction.yml.linux/amd64 linux/arm64, tags itX.Y.ZandX, confirms both tags resolve to the pinned digest, and movesvX.commitlint.yml: the source-buildcommitlintjob runs on both runners; the npm cache key includesrunner.arch.commitlint-from-published-imagestays amd64 only here: it runs the imageaction.ymlpins, which is amd64 only until this is released. An arm64 leg for it can follow the release.As a
feat:, merging this opens a 7.1.0 release PR.Checked locally:
jactionlint --online,prek run. Thepin-build/pin-commitimage steps were rehearsed against a local registry: both architectures built with the revision label, merged into an index holding exactlylinux/amd64 linux/arm64, a retag kept the digest, and the index ran natively as x64 and (emulated) arm64 on Node v26.13.0. The workflow itself first runs when this merges.🤖 Generated with Claude Code