From 8f2f4afe37658fca6a91645f6d13f026255582c3 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 1 Jun 2022 11:23:54 -0700 Subject: [PATCH 1/2] .github: add new job that builds all DEFAULT_PLATFORMS This will make sure platforms without an open-source toolchain available are added to SUPPORTED_PLATFORMS and do not break the -a option Signed-off-by: Marc Herbert --- .github/workflows/pull-request.yml | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 01639e699845..6f25c475adfc 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -83,6 +83,26 @@ jobs: run: ./scripts/host-testbench.sh + # This is a bit redundant with the other jobs below and with the (much + # faster!) installer[.yml] but it may differ in which platforms are + # built. This makes sure platforms without any open-source toolchain + # are added in the right place and do not accidentally break the -a + # option, Docker testing etc. + gcc-build-default-platforms: + runs-on: ubuntu-22.04 + + steps: + - uses: actions/checkout@v2 + with: {fetch-depth: 5, submodules: recursive} + + - name: docker + run: docker pull thesofproject/sof && docker tag thesofproject/sof sof + + - name: xtensa-build-all.sh -a + run: ./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a || + ./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a -j 1 + + gcc-build-only: runs-on: ubuntu-20.04 @@ -107,7 +127,7 @@ jobs: - name: docker run: docker pull thesofproject/sof && docker tag thesofproject/sof sof - - name: xtensa-build-all + - name: xtensa-build-all.sh platforms env: PLATFORM: ${{ matrix.platform }} run: ./scripts/docker-run.sh @@ -146,7 +166,7 @@ jobs: - name: docker SOF run: docker pull thesofproject/sof && docker tag thesofproject/sof sof - - name: xtensa-build-all -o no-agent + - name: xtensa-build-all.sh -o no-agent platforms env: PLATFORM: ${{ matrix.platform }} run: ./scripts/docker-run.sh From 0dc3053d267df7651ec329cd37dbf3294d533e5e Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 1 Jun 2022 11:25:26 -0700 Subject: [PATCH 2/2] .github: add mt8186 and mt8195 Thanks to Tinghan Shen and Fred Oh for making this happen. Signed-off-by: Marc Herbert --- .github/workflows/pull-request.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 6f25c475adfc..48305c3af746 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -109,14 +109,13 @@ jobs: strategy: fail-fast: false matrix: - # Use groups to avoid spamming the web interface. - # Don't use a single big group so a single failure does not block - # all other builds. + # Use groups to avoid spamming the web interface. Pay attention + # to COMMAS. Don't use a single big group so a single failure + # does not block all other builds. platform: [imx8ulp, sue jsl tgl, rn, - # TODO: enable mt81xx after docker image udpated - # mt8186, mt8195, + mt8186 mt8195, ] steps: