From b8d5822a6ac1d882402b5e93c8e960f131cc4d91 Mon Sep 17 00:00:00 2001 From: Kai Vehmanen Date: Wed, 16 Dec 2020 12:43:50 +0200 Subject: [PATCH] ASoC: SOF: add a pointer to download repo in case request FW fails The SOF firmware and topology files are not distributed via linux-firmware. To help debugging cases where correct firmware is not installed, print a pointer to the official upstream repository for Sound Open Firmware firmware binaries. BugLink: https://github.com/thesofproject/sof/issues/3665 Signed-off-by: Kai Vehmanen --- sound/soc/sof/loader.c | 2 ++ sound/soc/sof/topology.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c index 4ade55bf6d7519..6efaf766f2ab8d 100644 --- a/sound/soc/sof/loader.c +++ b/sound/soc/sof/loader.c @@ -731,6 +731,8 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev) if (ret < 0) { dev_err(sdev->dev, "error: request firmware %s failed err: %d\n", fw_filename, ret); + dev_err(sdev->dev, + "you may need to download the firmware from https://github.com/thesofproject/sof-bin/\n"); goto err; } else { dev_dbg(sdev->dev, "request_firmware %s successful\n", diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c index b69f493b5faa9a..2c9581c6b92dac 100644 --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -3732,6 +3732,8 @@ int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file) if (ret < 0) { dev_err(scomp->dev, "error: tplg request firmware %s failed err: %d\n", file, ret); + dev_err(scomp->dev, + "you may need to download the firmware from https://github.com/thesofproject/sof-bin/\n"); return ret; }