From b75eb649c709a8420c83bd9180a8cd811cbd8cc9 Mon Sep 17 00:00:00 2001 From: Pulkit Singhal Date: Tue, 21 Jun 2016 14:15:50 -0500 Subject: [PATCH 1/3] use exact versions to avoid unpredictable crashes possible reason behind crash when testing: 1.5.0-rc.1 fails to load in PhantomJS 1.x + Karma environment https://github.com/angular/angular.js/issues/13794 crash log: ``` PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR Error: [$injector:modulerr] Failed to instantiate module ng due to: TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply') at ... at /Users/shahwarcoder/loopback-sdk-angular/test.e2e/given.js:19 ``` --- package.json | 52 ++++++++++++++++++++++++++-------------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/package.json b/package.json index de4adf8..d3c9694 100644 --- a/package.json +++ b/package.json @@ -27,31 +27,31 @@ "ejs": "^1.0" }, "devDependencies": { - "angular": "^1.4.9", - "angular-mocks": "^1.4.9", - "angular-resource": "^1.4.9", - "bluebird": "^3.1.4", - "body-parser": "^1.5", - "chai": "^1.9", - "cors": "^2.2", - "debug": "^2.2.0", - "errorhandler": "^1.1.1", - "eslint": "^2.5.3", - "eslint-config-loopback": "^1.0.0", - "express": "^4.6", - "fs.extra": "^1.2", - "karma": "^0.13.19", - "karma-chrome-launcher": "^0.2.2", - "karma-junit-reporter": "^0.3.8", - "karma-mocha": "^0.2.1", - "karma-mocha-reporter": "^1.1.5", - "karma-phantomjs-launcher": "^0.2.3", - "karma-requirejs": "^0.2.1", - "loopback": "^2.0", - "loopback-datasource-juggler": "^2.0", - "mocha": "~1.18.0", - "morgan": "^1.2", - "phantomjs": "^1.9.19", - "requirejs": "^2.1.9" + "angular": "1.4.9", + "angular-mocks": "1.4.9", + "angular-resource": "1.4.9", + "bluebird": "3.1.4", + "body-parser": "1.5", + "chai": "1.9", + "cors": "2.2", + "debug": "2.2.0", + "errorhandler": "1.1.1", + "eslint": "2.5.3", + "eslint-config-loopback": "1.0.0", + "express": "4.6", + "fs.extra": "1.2", + "karma": "0.13.19", + "karma-chrome-launcher": "0.2.2", + "karma-junit-reporter": "0.3.8", + "karma-mocha": "0.2.1", + "karma-mocha-reporter": "1.1.5", + "karma-phantomjs-launcher": "0.2.3", + "karma-requirejs": "0.2.1", + "loopback": "2.0", + "loopback-datasource-juggler": "2.0", + "mocha": "1.18.0", + "morgan": "1.2", + "phantomjs": "1.9.19", + "requirejs": "2.1.9" } } From 903db3b8cafdf680c2b4706e66c6e071e5c4dabe Mon Sep 17 00:00:00 2001 From: Pulkit Singhal Date: Tue, 21 Jun 2016 14:20:45 -0500 Subject: [PATCH 2/3] Comment out failing lines from a test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit these are missing as aliases? 'updateOrCreate', 'removeById', 'destroyById', ``` LOG: 'methods', ['get', 'save', 'query', 'remove', 'delete', 'create', 'createMany', 'upsert', 'exists', 'findById', 'find', 'findOne', 'updateAll', 'deleteById', 'count', 'prototype$updateAttributes', 'bind', 'modelName'] ✖ has all methods including aliases ✔ has `modelName` property ``` --- test.e2e/spec/services.spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test.e2e/spec/services.spec.js b/test.e2e/spec/services.spec.js index 14ab31a..b6abac4 100644 --- a/test.e2e/spec/services.spec.js +++ b/test.e2e/spec/services.spec.js @@ -399,15 +399,15 @@ define(['angular', 'given', 'util'], function(angular, given, util) { expect(methodNames).to.include.members([ 'create', 'createMany', - 'updateOrCreate', + //'updateOrCreate', 'upsert', 'exists', 'findById', 'find', 'findOne', - 'destroyById', + //'destroyById', 'deleteById', - 'removeById', + //'removeById', 'count', 'prototype$updateAttributes', ]); From e22bde562c43648d264b7432f3d3d7f77635e22d Mon Sep 17 00:00:00 2001 From: Pulkit Singhal Date: Fri, 8 Jul 2016 12:57:40 -0500 Subject: [PATCH 3/3] loopback versions should not be constrained ... testing frameworks can be kept static by default to avoid surprises but loopback itself is meant to be tested alongside the sdk --- package.json | 4 ++-- test.e2e/spec/services.spec.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index d3c9694..4302108 100644 --- a/package.json +++ b/package.json @@ -47,8 +47,8 @@ "karma-mocha-reporter": "1.1.5", "karma-phantomjs-launcher": "0.2.3", "karma-requirejs": "0.2.1", - "loopback": "2.0", - "loopback-datasource-juggler": "2.0", + "loopback": "^2.0", + "loopback-datasource-juggler": "^2.0", "mocha": "1.18.0", "morgan": "1.2", "phantomjs": "1.9.19", diff --git a/test.e2e/spec/services.spec.js b/test.e2e/spec/services.spec.js index b6abac4..14ab31a 100644 --- a/test.e2e/spec/services.spec.js +++ b/test.e2e/spec/services.spec.js @@ -399,15 +399,15 @@ define(['angular', 'given', 'util'], function(angular, given, util) { expect(methodNames).to.include.members([ 'create', 'createMany', - //'updateOrCreate', + 'updateOrCreate', 'upsert', 'exists', 'findById', 'find', 'findOne', - //'destroyById', + 'destroyById', 'deleteById', - //'removeById', + 'removeById', 'count', 'prototype$updateAttributes', ]);