Skip to content

Update dependencies - #1454

Merged
michielbdejong merged 29 commits into
masterfrom
update-deps
Jul 30, 2020
Merged

michielbdejong merged 29 commits into
masterfrom
update-deps

Conversation

@michielbdejong

Copy link
Copy Markdown
Member

No description provided.

@michielbdejong
michielbdejong marked this pull request as draft July 24, 2020 14:01
@michielbdejong michielbdejong mentioned this pull request Jul 24, 2020
11 tasks done
@michielbdejong

Copy link
Copy Markdown
Member Author

500 on register:

curl 'https://localhost:8443/register' \
   -H 'content-type: application/json' \
   -H 'Origin: https://localhost:8443' \
   -H 'Referer: https://localhost:8443/common/popup.html' \
   --data-binary '{"issuer":"https://localhost:8443/","grant_types":["implicit"],"redirect_uris":["https://localhost:8443/.well-known/solid/login"],"response_types":["id_token token"],"scope":"openid profile"}' \
   --insecure

@michielbdejong

Copy link
Copy Markdown
Member Author

This is fixed by adding isomorphic-webcrypto as a workspace in mashlib-dev. This error also makes the tests of oidc-op fail. Basically, oidc-op requires isomorphic-webcrypto to create a key, then jose requires another instance of isomorphic-webcrypto to use the key. Before use, isomorphic-webcrypto checks whether the key is an instance of its own CryptoKey class, and that check then fails. Maybe the solution is if jose re-exports isomorphic-webcrypto, so all code uses the same instance.

@michielbdejong

Copy link
Copy Markdown
Member Author

Now looking into #1455

@michielbdejong
michielbdejong marked this pull request as ready for review July 30, 2020 19:19
@michielbdejong

Copy link
Copy Markdown
Member Author

@michielbdejong
michielbdejong merged commit 0542fa2 into master Jul 30, 2020
@michielbdejong
michielbdejong deleted the update-deps branch July 30, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant