Repository navigation
fix(ci): make the Claude PR review read the diff - #327
Merged
Merged
Conversation
The review job allowed only comment tools, so gh pr diff and Read were denied. Runs then posted the code-review plugin's stock "No issues found" line in about 30 seconds. Review in the foreground with diff and code tools, always post a summary, and fail the job when that did not happen. Co-authored-by: Le He <Annatar.He+github@gmail.com>
claude-code-action refuses to run a prompt from a workflow file that differs from the default branch, and that skip exits 0 with no log. Treat that case as a notice. A missing review on an unchanged workflow still fails the job. Co-authored-by: Le He <Annatar.He+github@gmail.com>
Match the review workflow that already works on rawback-app/web: the built-in /code-review high command, gh and git tools, and a check that fails only when the run spent nothing. Drop the plugin prompt and the background-task workaround. Co-authored-by: Le He <Annatar.He+github@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AnnatarHe
marked this pull request as ready for review
October 14, 2026 09:55
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automated Claude review was posting the code-review plugin's stock line,
No issues found. Checked for bugs and CLAUDE.md compliance., about 30 seconds after a push, without reading the diff. On shelltime/cli#325, run 38401010946 finished in 29s / 11 turns / $0.13 with two permission denials and no inline comments.--allowedToolscontained only the inline-comment tool andgh pr comment, sogh pr diffandReadwere refused. The plugin's command then posts that fixed sentence whenever it has no high-signal bug. An earlier run on the same PR exited in 6s / 3 turns and posted nothing.CLAUDE_CODE_DISABLE_BACKGROUND_TASKS=1was already set; it stops the action from returning before background subagents finish, and it did not fix a review that was not allowed to read the diff.The working setup is the built-in
/code-reviewcommand used byrawback-app/web(attached) and the other repos aligned to it. This workflow now matches that file. The runner staysblacksmith-2vcpu-ubuntu-2404. The one comment change is that Actions logs here are public, so the reference's "repository is private" note is not copied.claude.ymlis untouched.What the reference does differently
claude-review-<number>).action_required.pull-requests: write,issues: write, and read on checks, statuses, and actions, withadditional_permissions: actions: read, so the review can post and can read CI.fetch-depth: 0) sogit diff,git log, andgit blamework against the base./code-review high <PR#> --commentinstead ofcode-review@claude-code-plugins. On rawback-app/web#654 the plugin's main loop skipped its own subagents, read a slice of a large diff, and posted "No issues found" after 16 seconds. The built-in command takes an effort level and--comment, and it checks findings before posting them.Bash(gh:*),Bash(git:*), and the inline-comment tool. The broken allowlist was comment tools only.show_full_output).num_turnsis 0 and cost is $0; warn when no Agent/Task/Workflow subagent was launched; warn and pass when there is no execution file (expected while this workflow file differs frommain).CLAUDE_CODE_DISABLE_BACKGROUND_TASKS. That variable was a workaround for the plugin's background subagents. The built-in command is the path that actually reviews.Test plan
rawback-app/webaside from the public-log comment and trailing blank lines./code-review high, and the assert step fails only for a 0-turn, $0 run.@claudementions still go throughclaude.yml, which this PR does not change.Need help on this PR? Tag
@codesmith-botwith what you need.