Skip to content

Commit 2d43c37

Browse files
committed
refactor: rename IDEE_NIGHTLY_RELEASE_WEBHOOK secret to generic SLACK_WEBHOOK
Per review feedback: this is a generic reusable workflow, so the declared secret name shouldn't bake in a consumer-specific naming convention. The actual GitHub secret name a caller stores doesn't need to match this internal declaration unless using secrets: inherit, in which case it does need to match -- so the stored secrets in each consumer repo are being renamed to SLACK_WEBHOOK to match, rather than switching callers from inherit to explicit secret mapping.
1 parent 348eb2e commit 2d43c37

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎.github/workflows/vscode-publish-extensions.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ on:
176176
MARKETPLACE_DEPLOY_TOKEN:
177177
description: "CBWeb internal marketplace publishing token"
178178
required: false
179-
IDEE_NIGHTLY_RELEASE_WEBHOOK:
179+
SLACK_WEBHOOK:
180180
description: "Slack notification webhook"
181181
required: false
182182

@@ -1239,7 +1239,7 @@ jobs:
12391239
- name: Notify Slack
12401240
if: inputs.dry-run != 'true' && github.event.inputs.dry-run != 'true' && needs.publish.result == 'success'
12411241
env:
1242-
SLACK_WEBHOOK_URL: ${{ secrets.IDEE_NIGHTLY_RELEASE_WEBHOOK }}
1242+
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}
12431243
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
12441244
REGISTRIES: ${{ inputs.registries }}
12451245
EXTENSION_NAMES: ${{ steps.extension-details.outputs.extension_display_names }}
@@ -1342,7 +1342,7 @@ jobs:
13421342
- name: Notify Slack
13431343
if: inputs.dry-run != 'true' && github.event.inputs.dry-run != 'true' && (needs.publish.result == 'failure' || needs.bump-versions.result == 'failure' || needs.package.result == 'failure')
13441344
env:
1345-
SLACK_WEBHOOK_URL: ${{ secrets.IDEE_NIGHTLY_RELEASE_WEBHOOK }}
1345+
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}
13461346
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
13471347
REGISTRIES: ${{ inputs.registries }}
13481348
EXTENSION_NAMES: ${{ steps.extension-details.outputs.extension_display_names }}

0 commit comments

Comments
 (0)