From 550ba613b5ccb386e23aa32d234a3fc1934a0761 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Tue, 16 Aug 2022 15:55:39 +0300 Subject: [PATCH 1/2] Remove `@final` from subclassesable types --- stdlib/collections/__init__.pyi | 3 --- 1 file changed, 3 deletions(-) diff --git a/stdlib/collections/__init__.pyi b/stdlib/collections/__init__.pyi index 40cf999dfae1..085b32fd155d 100644 --- a/stdlib/collections/__init__.pyi +++ b/stdlib/collections/__init__.pyi @@ -301,15 +301,12 @@ class Counter(dict[_T, int], Generic[_T]): def __ge__(self, other: Counter[Any]) -> bool: ... def __gt__(self, other: Counter[Any]) -> bool: ... -@final class _OrderedDictKeysView(dict_keys[_KT_co, _VT_co], Reversible[_KT_co]): # type: ignore[misc] def __reversed__(self) -> Iterator[_KT_co]: ... -@final class _OrderedDictItemsView(dict_items[_KT_co, _VT_co], Reversible[tuple[_KT_co, _VT_co]]): # type: ignore[misc] def __reversed__(self) -> Iterator[tuple[_KT_co, _VT_co]]: ... -@final class _OrderedDictValuesView(dict_values[_KT_co, _VT_co], Reversible[_VT_co], Generic[_KT_co, _VT_co]): # type: ignore[misc] def __reversed__(self) -> Iterator[_VT_co]: ... From 6f8862613ed1fef0d83129c8cc08e1e14d19004c Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Tue, 16 Aug 2022 15:59:28 +0300 Subject: [PATCH 2/2] Update __init__.pyi --- stdlib/collections/__init__.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/collections/__init__.pyi b/stdlib/collections/__init__.pyi index 085b32fd155d..b4b494de560b 100644 --- a/stdlib/collections/__init__.pyi +++ b/stdlib/collections/__init__.pyi @@ -2,7 +2,7 @@ import sys from _collections_abc import dict_items, dict_keys, dict_values from _typeshed import Self, SupportsKeysAndGetItem, SupportsRichComparison, SupportsRichComparisonT from typing import Any, Generic, NoReturn, TypeVar, overload -from typing_extensions import SupportsIndex, final +from typing_extensions import SupportsIndex if sys.version_info >= (3, 9): from types import GenericAlias