From 9e1732f268faf04bab8e0ba8f6cd0f489787e53d Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Mon, 19 Nov 2018 09:26:36 +0100 Subject: [PATCH] Accept upstream stubs when receiving no response Also, don't explicitly ask for people to ask for missing packages. Closes #2573 --- CONTRIBUTING.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 106994bbcbd7..d347ff9264a6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -29,8 +29,8 @@ For more details, read below. ## Discussion If you've run into behavior in the type checker that suggests the type -stubs for a given library are incorrect or incomplete, or a library you -depend on is missing type annotations, we want to hear from you! +stubs for a given library are incorrect or incomplete, +we want to hear from you! Our main forum for discussion is the project's [GitHub issue tracker](https://github.com/python/typeshed/issues). This is the right @@ -111,8 +111,9 @@ know and **get their permission**. Do it by opening an issue on their project's bug tracker. This gives them the opportunity to consider adopting type hints directly in their codebase (which you should prefer to external type stubs). When the project owners agree -for you to submit stubs here, open a pull request **referencing the -message where you received permission**. +for you to submit stubs here or you do not receive a reply within +one month, open a pull request **referencing the +issue where you asked for permission**. Make sure your changes pass the tests (the [README](README.md#running-the-tests) has more information).