From 2ffb99a0666ffb9ca475b84993ac3c1b23609f58 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Sun, 17 Apr 2022 12:42:07 -0700 Subject: [PATCH 1/2] deprecate telnetlib --- Lib/telnetlib.py | 3 +++ Lib/test/test_telnetlib.py | 5 +++-- .../Library/2022-04-17-12-41-52.gh-issue-91217.3wnHSX.rst | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2022-04-17-12-41-52.gh-issue-91217.3wnHSX.rst diff --git a/Lib/telnetlib.py b/Lib/telnetlib.py index ae88ea594746fd8..62d636129853ad1 100644 --- a/Lib/telnetlib.py +++ b/Lib/telnetlib.py @@ -37,6 +37,9 @@ import socket import selectors from time import monotonic as _time +import warnings + +warnings._deprecated(__name__, remove=(3, 13)) __all__ = ["Telnet"] diff --git a/Lib/test/test_telnetlib.py b/Lib/test/test_telnetlib.py index b50df1459d1f4c3..a9cade2ee466f99 100644 --- a/Lib/test/test_telnetlib.py +++ b/Lib/test/test_telnetlib.py @@ -1,15 +1,16 @@ import socket import selectors -import telnetlib import threading import contextlib from test import support -from test.support import socket_helper +from test.support import socket_helper, warnings_helper import unittest support.requires_working_socket(module=True) +telnetlib = warnings_helper.import_deprecated('telnetlib') + HOST = socket_helper.HOST def server(evt, serv): diff --git a/Misc/NEWS.d/next/Library/2022-04-17-12-41-52.gh-issue-91217.3wnHSX.rst b/Misc/NEWS.d/next/Library/2022-04-17-12-41-52.gh-issue-91217.3wnHSX.rst new file mode 100644 index 000000000000000..6c4acc7924332ed --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-04-17-12-41-52.gh-issue-91217.3wnHSX.rst @@ -0,0 +1 @@ +Deprecate the telnetlib module. From e11f11aeea0bb5eb86cffc795998130c84811eb8 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Tue, 26 Apr 2022 07:13:14 -0700 Subject: [PATCH 2/2] Add to What's New --- Doc/whatsnew/3.11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 8f0d3c7c7099a37..b812658d5e91e8f 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -1069,6 +1069,7 @@ Deprecated * :mod:`sndhdr` * :mod:`spwd` * :mod:`sunau` + * :mod:`telnetlib` (Contributed by Brett Cannon in :issue:`47061`.)