From f9c32dff19707d2c7654ce1eef8da7206317dc9d Mon Sep 17 00:00:00 2001 From: sobolevn Date: Fri, 14 Mar 2025 12:11:40 +0300 Subject: [PATCH 1/2] gh-131219: Improve tests in `test_lzma.py` by adding more asserts --- Lib/test/test_lzma.py | 44 ++++++++++++++++++++++++++----------------- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/Lib/test/test_lzma.py b/Lib/test/test_lzma.py index 22478c14fb4a65..f6fe8b6ae7443c 100644 --- a/Lib/test/test_lzma.py +++ b/Lib/test/test_lzma.py @@ -538,13 +538,17 @@ class FileTestCase(unittest.TestCase): def test_init(self): with LZMAFile(BytesIO(COMPRESSED_XZ)) as f: - pass + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "rb") with LZMAFile(BytesIO(), "w") as f: - pass + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") with LZMAFile(BytesIO(), "x") as f: - pass + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") with LZMAFile(BytesIO(), "a") as f: - pass + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") def test_init_with_PathLike_filename(self): filename = FakePath(TESTFN) @@ -573,25 +577,31 @@ def test_init_with_filename(self): def test_init_mode(self): with TempFile(TESTFN): - with LZMAFile(TESTFN, "r"): - pass - with LZMAFile(TESTFN, "rb"): - pass - with LZMAFile(TESTFN, "w"): - pass - with LZMAFile(TESTFN, "wb"): - pass - with LZMAFile(TESTFN, "a"): - pass - with LZMAFile(TESTFN, "ab"): - pass + with LZMAFile(TESTFN, "r") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "rb") + with LZMAFile(TESTFN, "rb") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "rb") + with LZMAFile(TESTFN, "w") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") + with LZMAFile(TESTFN, "wb") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") + with LZMAFile(TESTFN, "a") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") + with LZMAFile(TESTFN, "ab") as f: + self.assertIsInstance(f, LZMAFile) + self.assertEqual(f.mode, "wb") def test_init_with_x_mode(self): self.addCleanup(unlink, TESTFN) for mode in ("x", "xb"): unlink(TESTFN) with LZMAFile(TESTFN, mode) as f: - pass + self.assertIsInstance(f, LZMAFile) self.assertEqual(f.mode, 'wb') with self.assertRaises(FileExistsError): LZMAFile(TESTFN, mode) From d7948285a96d2f9e0840238a5dcd4ddcdf932e2f Mon Sep 17 00:00:00 2001 From: sobolevn Date: Fri, 14 Mar 2025 12:51:53 +0300 Subject: [PATCH 2/2] Address review --- Lib/test/test_lzma.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_lzma.py b/Lib/test/test_lzma.py index f6fe8b6ae7443c..4dd10faf71360a 100644 --- a/Lib/test/test_lzma.py +++ b/Lib/test/test_lzma.py @@ -602,7 +602,7 @@ def test_init_with_x_mode(self): unlink(TESTFN) with LZMAFile(TESTFN, mode) as f: self.assertIsInstance(f, LZMAFile) - self.assertEqual(f.mode, 'wb') + self.assertEqual(f.mode, 'wb') with self.assertRaises(FileExistsError): LZMAFile(TESTFN, mode)