From 03f8ddb5bd0966a650574e48297858d84717c167 Mon Sep 17 00:00:00 2001 From: Diego Rojas Date: Thu, 14 Mar 2019 12:03:22 -0500 Subject: [PATCH 1/3] Update news entry for XML order attributes --- Doc/whatsnew/3.8.rst | 4 ++++ Misc/ACKS | 1 + 2 files changed, 5 insertions(+) diff --git a/Doc/whatsnew/3.8.rst b/Doc/whatsnew/3.8.rst index 31ea0d1458195cc..99123fd5671f8b8 100644 --- a/Doc/whatsnew/3.8.rst +++ b/Doc/whatsnew/3.8.rst @@ -614,6 +614,10 @@ Changes in the Python API specialized methods like :meth:`~tkinter.ttk.Treeview.selection_set` for changing the selection. (Contributed by Serhiy Storchaka in :issue:`31508`.) +* The :meth: `writexml`, :meth: `toxml` and :meth: `toprettyxml` methods + now preserves the attribute order specified by the user. + (Contributed by Diego Rojas and Raymond Hettinger in :issue: `34160`.) + * A :mod:`dbm.dumb` database opened with flags ``'r'`` is now read-only. :func:`dbm.dumb.open` with flags ``'r'`` and ``'w'`` no longer creates a database if it does not exist. diff --git a/Misc/ACKS b/Misc/ACKS index 2026852db1a1121..9cddcb3a871f70d 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -1847,3 +1847,4 @@ Doug Zongker Peter Åstrand Zheao Li Carsten Klein +Diego Rojas From 586edc8411857b39d2026d5817c1215420120322 Mon Sep 17 00:00:00 2001 From: Diego Rojas Date: Thu, 14 Mar 2019 22:59:54 -0500 Subject: [PATCH 2/3] Fix reST syntax --- Doc/whatsnew/3.8.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.8.rst b/Doc/whatsnew/3.8.rst index 99123fd5671f8b8..a15cace7e9b66ad 100644 --- a/Doc/whatsnew/3.8.rst +++ b/Doc/whatsnew/3.8.rst @@ -614,9 +614,9 @@ Changes in the Python API specialized methods like :meth:`~tkinter.ttk.Treeview.selection_set` for changing the selection. (Contributed by Serhiy Storchaka in :issue:`31508`.) -* The :meth: `writexml`, :meth: `toxml` and :meth: `toprettyxml` methods +* The :meth:`writexml`, :meth:`toxml` and :meth:`toprettyxml` methods now preserves the attribute order specified by the user. - (Contributed by Diego Rojas and Raymond Hettinger in :issue: `34160`.) + (Contributed by Diego Rojas and Raymond Hettinger in :issue:`34160`.) * A :mod:`dbm.dumb` database opened with flags ``'r'`` is now read-only. :func:`dbm.dumb.open` with flags ``'r'`` and ``'w'`` no longer creates From ee4cdd314ed593d55a4326fb9c5d88d45ae94876 Mon Sep 17 00:00:00 2001 From: dfrojas Date: Sat, 16 Mar 2019 11:43:00 -0500 Subject: [PATCH 3/3] Listing modules modified and fix typo --- Doc/whatsnew/3.8.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.8.rst b/Doc/whatsnew/3.8.rst index a15cace7e9b66ad..eaa3f5b79f05658 100644 --- a/Doc/whatsnew/3.8.rst +++ b/Doc/whatsnew/3.8.rst @@ -614,8 +614,9 @@ Changes in the Python API specialized methods like :meth:`~tkinter.ttk.Treeview.selection_set` for changing the selection. (Contributed by Serhiy Storchaka in :issue:`31508`.) -* The :meth:`writexml`, :meth:`toxml` and :meth:`toprettyxml` methods - now preserves the attribute order specified by the user. +* The :meth:`writexml`, :meth:`toxml` and :meth:`toprettyxml` methods of the + :mod:`xml.dom.minidom` module, and :mod:`xml.etree` now preserve the attribute + order specified by the user. (Contributed by Diego Rojas and Raymond Hettinger in :issue:`34160`.) * A :mod:`dbm.dumb` database opened with flags ``'r'`` is now read-only.