From d74e335498d06a1b710b7d1d21959174ea04e2aa Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 11 Oct 2023 15:22:18 +0200 Subject: [PATCH 1/2] Issue #419: Only add Tier-1 and Tier-2 builders to Release Status --- master/custom/builders.py | 9 +++++++++ master/master.cfg | 6 +++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/master/custom/builders.py b/master/custom/builders.py index 034f0c94..6cff6acf 100644 --- a/master/custom/builders.py +++ b/master/custom/builders.py @@ -43,8 +43,17 @@ Wasm32WASIBuild, ) +# A builder can be marked as stable when at least the 10 latest builds are +# successful, but it's way better to wait at least for at least one week of +# successful builds before considering to mark a builder as stable. STABLE = "stable" + +# New builders should always be marked as unstable. If a stable builder starts +# to fail randomly, it can be downgraded to unstable if it is not a Tier-1 or +# Tier-2 builder. UNSTABLE = "unstable" + +# https://peps.python.org/pep-0011/ defines Platfom Support Tiers TIER_1 = "tier-1" TIER_2 = "tier-2" TIER_3 = "tier-3" diff --git a/master/master.cfg b/master/master.cfg index e6c90efa..b4da8bea 100644 --- a/master/master.cfg +++ b/master/master.cfg @@ -198,6 +198,7 @@ def is_important_change(change): github_status_builders = [] +release_status_builders = [] mail_status_builders = [] # Regular builders @@ -252,6 +253,9 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches): # disable GitHub notifications for unstable builders if stability == STABLE: github_status_builders.append(buildername) + # Only Tier-1 and Tier-2 builders can block a release + if tier in (TIER_1, TIER_2): + release_status_builders.append(buildername) tags = [branchname, stability,] + getattr(f, "tags", []) if tier: tags.append(tier) @@ -521,7 +525,7 @@ c['www']['plugins']['wsgi_dashboards'] = [ { 'name': 'release_status', 'caption': 'Release Status', - 'app': get_release_status_app(github_status_builders), + 'app': get_release_status_app(release_status_builders), 'order': 2, 'icon': 'rocket' } From 857a722455281214d02bf1058771c5cac12208bc Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 11 Oct 2023 15:27:07 +0200 Subject: [PATCH 2/2] Fix missing import --- master/master.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/master/master.cfg b/master/master.cfg index b4da8bea..5c4c222b 100644 --- a/master/master.cfg +++ b/master/master.cfg @@ -58,6 +58,7 @@ from custom.builders import ( STABLE, DAILYBUILDERS, ONLY_MAIN_BRANCH, + TIER_1, TIER_2, ) # noqa: E402 def set_up_sentry():